[ 
https://issues.apache.org/jira/browse/CASSANDRA-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073015#comment-18073015
 ] 

Stefan Miklosovic commented on CASSANDRA-21247:
-----------------------------------------------

There are some failing tests, it fails on this (same failure on Paulo's link in 
Jenkins)

[CASSANDRA-21247|https://github.com/instaclustr/cassandra/tree/CASSANDRA-21247]
{noformat}  
java11_separate_tests                            
  ✓ j11_build                                         9m 7s
    j11_dtests_latest                               27m 27s
  ✕ j17_dtests_latest                               46m 20s
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_parallel_repair
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_parallel_repair
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_parallel_repair
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_sequential_repair
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_sequential_repair
      repair_tests.repair_test.TestRepair test_empty_vs_gcable_sequential_repair
{noformat}

[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/6357/workflows/7aca8a4e-ad1b-4782-974c-d1ee117efaa7]

In that test we set gc_grace_seconds to 1s. I think we should either update the 
test or we should increase the minimum threshold (via CASSANDRA-21293) first 
and make it default (e.g. 1h). I prefer the latter. We can postpone the merge 
of this until CASSANDRA-21293 is delivered.

https://github.com/apache/cassandra-dtest/blob/trunk/repair_tests/repair_test.py#L484

> Enable check_data_resurrection by default in cassandra_latest.yaml
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-21247
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21247
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Startup and Shutdown
>            Reporter: Isaac Reath
>            Assignee: Isaac Reath
>            Priority: Normal
>             Fix For: 6.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The check_data_resurrection configuration was added to 4.1 in CASSANDRA-17180 
> to prevent nodes from starting up if a node has been offline longer than the 
> minimum gc_grace_seconds. While this feature is critical for ensuring that we 
> don't resurrect data, there are members of the community who may not know 
> that it was added (CASSANDRA-21221 for example).
> This ticket proposes enabling this setting by default in 
> cassandra_latest.yaml so that users who take the most recent production 
> settings from this file are able to automatically benefit from this feature 
> in the next major release. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to