[
https://issues.apache.org/jira/browse/CASSANALYTICS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072380#comment-18072380
]
Josh McKenzie commented on CASSANALYTICS-146:
---------------------------------------------
gh CI looks as clean as other gh CI at this point. Circle's a bit of a mess
right now so not much signal there. Should be ready for review.
> Remove StorageService shutdown hooks in ecosystem integration testing to
> prevent race on transaction log deletion
> -----------------------------------------------------------------------------------------------------------------
>
> Key: CASSANALYTICS-146
> URL: https://issues.apache.org/jira/browse/CASSANALYTICS-146
> Project: Apache Cassandra Analytics
> Issue Type: Task
> Components: CI
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When tests timeout the teardown on the in-jvm dtests races with
> StorageService’s shutdown hooks and lifecycle transaction files get
> double-deleted leading to thousands of lines of horrible useless log messages
> during failure.
> This is particularly painful in the ecosystem integration tests as we stand
> up a lot of nodes and infra and it exposes us more to this kind of collision.
> The signal to noise ratio on timeout tests is brutal due to thousands of
> lines of "FSWriteError" on a bunch of lifecycle transaction /tmp files.
> We should have no real risk of regression in the future since in tests we
> rely on forcing flushes in C* nodes to check sstables and other files, so the
> “are your memtables flushed on node shutdown during tests” question in the
> ecosystem shouldn’t ever come up."
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
