[
https://issues.apache.org/jira/browse/CASSANDRA-21187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072070#comment-18072070
]
Sam Tunnicliffe edited comment on CASSANDRA-21187 at 4/8/26 7:19 PM:
---------------------------------------------------------------------
Thanks [~minalkyada], I've rebased and re-run CI and it looks in fairly good
shape so I've merged the patch (updated CI summary and details files are
attached).
I made two slight tweaks as I did that:
* Just for clarity I added the {{system}} keyspace name to the log messages
in {{{}SystemPeersValidator{}}}.
* Added a system property to control whether we run the validator on every
startup.
I've enabled this by default, but it gives operators a way to disable if it's
either too noisy or not useful
(e.g. I'm thinking of the scenario [~ifesdjeen] mentioned on the PR of
running multiple instances with the same IP
but distinct ports).
My branch with those tweaks which I ran the CI on is
[here|https://github.com/beobal/cassandra/commits/samt/CASSANDRA-21187/]
was (Author: beobal):
Thanks [~minalkyada], I've rebased and re-run CI and it looks in fairly good
shape so I've merged the patch.
I made two slight tweaks as I did that:
* Just for clarity I added the {{system}} keyspace name to the log messages in
{{SystemPeersValidator}}.
* Added a system property to control whether we run the validator on every
startup.
I've enabled this by default, but it gives operators a way to disable if it's
either too noisy or not useful
(e.g. I'm thinking of the scenario [~ifesdjeen] mentioned on the PR of
running multiple instances with the same IP
but distinct ports).
My branch with those tweaks which I ran the CI on is
[here|https://github.com/beobal/cassandra/commits/samt/CASSANDRA-21187/]
> Make sure system.peers and peers_v2 match cluster metadata
> ----------------------------------------------------------
>
> Key: CASSANDRA-21187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21187
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Cluster/Membership
> Reporter: Minal Kyada
> Assignee: Minal Kyada
> Priority: Normal
> Fix For: 6.0-alpha2
>
> Attachments: ci_summary-1.html, ci_summary.html,
> result_details.tar-1.gz, result_details.tar.gz
>
>
> We should check that peers and peers_v2 match cluster metadata, either on
> startup or potentially every time we update those tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
