[
https://issues.apache.org/jira/browse/CASSANDRA-21290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071927#comment-18071927
]
Stefan Miklosovic commented on CASSANDRA-21290:
-----------------------------------------------
+1 on trunk patch. I have backported it to 5.0 here. (1). I have applied some
minor fixes in there.
(1) 5.0 https://github.com/smiklosovic/cassandra/tree/CASSANDRA-21290-5.0
(2) trunk https://github.com/smiklosovic/cassandra/tree/CASSANDRA-21290
[~clohfink] could you please +1 this too as a second reviewer we need?
> Implement atomic heartbeat file write
> -------------------------------------
>
> Key: CASSANDRA-21290
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21290
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Legacy/Core
> Reporter: John Lu
> Assignee: John Lu
> Priority: Normal
> Fix For: 5.0.x, 6.x
>
>
> It is possible for an empty heartbeat file to be written, potentially due to
> crash between file creation and the actual write. We can instead write to a
> temporary heartbeat file and then do an atomic move to rename it to the
> actual heartbeat file.
>
> Also fall back to the last modified time of the heartbeat file in case the
> file is not able to be parsed (it wont be able to be parsed if its empty)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
