Klose6 commented on code in PR #187:
URL:
https://github.com/apache/cassandra-analytics/pull/187#discussion_r3025965349
##########
cassandra-analytics-cdc-sidecar/src/main/java/org/apache/cassandra/cdc/sidecar/SidecarCdcBuilder.java:
##########
@@ -43,6 +44,8 @@ public class SidecarCdcBuilder extends CdcBuilder
{
protected ClusterConfigProvider clusterConfigProvider;
protected SidecarCdcClient sidecarCdcClient;
+ @NotNull
+ protected Function<String, Integer> portResolver;
Review Comment:
sure, I added the preexisting behavior in the constructor and another new
constructor for the new portResolver parameter, also I just found this latest
[commit](https://github.com/apache/cassandra-analytics/commit/dfface1be7a0d70e745b6e0732e681bde237508c#diff-1e824b92860d2a734894ee972f24297f4f30cf450359333224a947b48c49c7ae)
so I add the withPortResolver() in SidecarCdcClient and SidecarCdcBuilder to
support the port resolving. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
