[
https://issues.apache.org/jira/browse/CASSANALYTICS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070141#comment-18070141
]
Jyothsna Konisa commented on CASSANALYTICS-142:
-----------------------------------------------
CI :
https://app.circleci.com/pipelines/github/jyothsnakonisa/cassandra-analytics/75/workflows/55d67c7e-02c7-48ff-8a8d-79f99cf3c0e1
> SidecarCdcClient should be passed as a constructor parameter for SidecarCdc
> to avoid thread/resource leaks
> ----------------------------------------------------------------------------------------------------------
>
> Key: CASSANALYTICS-142
> URL: https://issues.apache.org/jira/browse/CASSANALYTICS-142
> Project: Apache Cassandra Analytics
> Issue Type: Bug
> Reporter: Jyothsna Konisa
> Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Identified a thread/resource leaks in CDC code path
> 1. SidecarCdcClient object is being created for each token range inside
> sidecar. This object holds a reference to vertx object which is never closed.
> During failures, new SidecarCdcClient objects are created on each retry
> causing resource leaks.
> 2.SidecarCdcClient is not autoclosable, hence SidecarClient object reference
> by SidecarCdcClient is never closed.
> 3. StatePersister class is started but close is never called in sidecar
> We should have a singleton SidecarCdcClient, adding a constructor parameter
> in SidecarCdc to be able to pass singleton SidecarCdcClient created in
> sidecar. Also making the SidecarCdcClient auto closable to be closed from
> sidecar while managing the lifecycle.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
