skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r2988872994
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/bridge/CassandraVersion.java:
##########
@@ -35,22 +37,49 @@
*/
public enum CassandraVersion
{
- THREEZERO(30, "3.0", "three-zero", "big"),
- FOURZERO(40, "4.0", "four-zero", "big"),
- FOURONE(41, "4.1", "four-zero", "big"),
- FIVEZERO(50, "5.0", "five-zero", "big", "bti");
+ THREEZERO(30, "3.0", "three-zero", new String[]{"big"},
+ new String[]{
+ // Cassandra 3.x native sstable versions
+ // order is important, used to determine the latest version
Review Comment:
Yes, regardless of which sstable version found in a given Cassandra version,
we choose that cassandra version as long as there is no sstable version from
higher cassandra version. So the order of sstable versions within a cassandra
version doesn't matter. Updated the sorting logic not to depend on array index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
