skoppu22 commented on code in PR #183:
URL:
https://github.com/apache/cassandra-analytics/pull/183#discussion_r2959567903
##########
cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/db/DbUtils.java:
##########
@@ -33,23 +33,27 @@ private DbUtils()
throw new IllegalStateException(getClass() + " is static utility class
and shall not be instantiated");
}
- public static DeletionTime deletionTime(long markedForDeleteAt, int
localDeletionTime)
+ // C* 4.0 DeletionTime constructor requires int for localDeletionTime;
checked cast will throw after Y2038
+ public static DeletionTime deletionTime(long markedForDeleteAt, long
localDeletionTime)
Review Comment:
Why are these methods test only? I see DbUtils methods are being called from
AbstractCdcBridgeImplementation.
##########
cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/spark/reader/AbstractStreamScanner.java:
##########
@@ -443,7 +444,8 @@ public void consume()
Cell<?> cell = cells.next();
// Re: isLive vs. isTombstone - isLive considers TTL so
that if a cell is expiring soon,
// it is handled as tombstone
- if (cell.isLive(timeProvider.referenceEpochInSeconds()))
+ // C* 4.0 Cell.isLive requires int for nowInSec; checked
cast will throw after Y2038
+ if
(cell.isLive(Ints.checkedCast(timeProvider.referenceEpochInSeconds())))
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
