[
https://issues.apache.org/jira/browse/CASSANALYTICS-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064813#comment-18064813
]
Jyothsna Konisa commented on CASSANALYTICS-127:
-----------------------------------------------
CI report:
https://app.circleci.com/pipelines/github/jyothsnakonisa/cassandra-analytics/56/workflows/d5d47d4c-a004-47b1-8474-9e588844db52
> Fixing CdcTests.testMockedCdc broken due to incorrect position update in
> BufferingCommitLogReader
> -------------------------------------------------------------------------------------------------
>
> Key: CASSANALYTICS-127
> URL: https://issues.apache.org/jira/browse/CASSANALYTICS-127
> Project: Apache Cassandra Analytics
> Issue Type: Bug
> Components: CDC
> Reporter: Jyothsna Konisa
> Assignee: Jyothsna Konisa
> Priority: Normal
> Fix For: 0.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The commit
> https://github.com/apache/cassandra-analytics/commit/34c6c38253d59a9fe8485368fea3145e2dffe205
> introduced the following change in BufferingCommitlogReader after reading
> all the sync segments in the commit log file with out checking the completion
> status of the commit log. This marks the commitlog as read even if it is not
> complete which is incorrect.
> if (statusTracker.shouldContinue())
> {
> this.position = (int) log.maxOffset();
> }
> Also, this block is not needed as the position is correctly updated to the
> file pointer when sync segments are read.
> This change also breaks the test CdcTests.testMockedCdc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
