jmckenzie-dev commented on code in PR #178:
URL:
https://github.com/apache/cassandra-analytics/pull/178#discussion_r2907523491
##########
cassandra-analytics-cdc/src/main/java/org/apache/cassandra/cdc/Cdc.java:
##########
@@ -442,5 +454,6 @@ protected void refreshSchema()
public void close()
{
this.stop();
+ statePersister.stop();
Review Comment:
In `runsafe()` we have the following:
```
else
{
LOGGER.error("CdcConsumer epoch failed with unrecoverable
error jobId={} partition={} epoch={}",
jobId, partitionId, currentState.epoch, t);
stop();
}
```
That seems to go through the stop() path w/out triggering the statePersister
stop? Best I can tell, the runSafe path still has a hole there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
