yifan-c commented on code in PR #102:
URL:
https://github.com/apache/cassandra-analytics/pull/102#discussion_r1994134904
##########
cassandra-four-zero-types/build.gradle:
##########
@@ -33,6 +33,7 @@ dependencies {
compileOnly project(":cassandra-analytics-common")
compileOnly(project(path: ':cassandra-four-zero', configuration: 'shadow'))
compileOnly "com.esotericsoftware:kryo-shaded:${kryoVersion}"
+ compileOnly(group: "${sparkGroupId}", name:
"spark-core_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
Review Comment:
For the write-path, the converters are located at a different place. Check
out `org.apache.cassandra.spark.bulkwriter.SqlToCqlTypeConverter`.
They should be consolidated, but it is what it is as of today.
A nit on the class name. How about calling it `InternalDuration` instead of
`DurationWrapper`? Since it does not wrap anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
