DenisIstomin commented on a change in pull request #4101:
URL: https://github.com/apache/camel/pull/4101#discussion_r475276617
##########
File path:
components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioComponentIntegrationTest.java
##########
@@ -33,18 +36,22 @@
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
-@Disabled("Must be manually tested. Provide your own accessKey and secretKey!")
+@Disabled("Goto https://play.min.io and search for 'mycamelbucket'. If
bucket(s) does not exist, set 'autoCreateBucket=true' in route(s)")
public class MinioComponentIntegrationTest extends CamelTestSupport {
Review comment:
Junit5 is used, would be better to remove `public` access modifier in
all test classes and all tests methods. So they will have default access
modifier:
```
class MinioComponentIntegrationTest extends CamelTestSupport {
```
##########
File path:
components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioComponentIntegrationTest.java
##########
@@ -33,18 +36,22 @@
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
-@Disabled("Must be manually tested. Provide your own accessKey and secretKey!")
+@Disabled("Goto https://play.min.io and search for 'mycamelbucket'. If
bucket(s) does not exist, set 'autoCreateBucket=true' in route(s)")
public class MinioComponentIntegrationTest extends CamelTestSupport {
+ final Properties properties = MinioTestUtils.loadMinioPropertiesFile();
@EndpointInject("direct:start")
private ProducerTemplate template;
@EndpointInject("mock:result")
private MockEndpoint result;
+ public MinioComponentIntegrationTest() throws IOException {
+ }
+
@Test
public void sendInOnly() throws Exception {
Review comment:
Junit5 is used, would be better to remove `public` access modifier in
all test classes and all tests methods. So they will have default access
modifier:
```
void sendInOnly() throws Exception {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
