DenisIstomin commented on a change in pull request #3897: URL: https://github.com/apache/camel/pull/3897#discussion_r449651579
########## File path: components/camel-minio/src/test/java/org/apache/camel/component/minio/MinioComponentTest.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.minio; + +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.test.junit4.CamelTestSupport; +import org.junit.Test; + +public class MinioComponentTest extends CamelTestSupport { + + @Test + public void testMinio() throws Exception { + MockEndpoint mock = getMockEndpoint("mock:result"); + mock.expectedMinimumMessageCount(1); + + assertMockEndpointsSatisfied(); Review comment: Looks like that test should fail, because there are no messages being sent. ########## File path: components/camel-minio/src/main/java/org/apache/camel/component/minio/MinioConsumer.java ########## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.minio; + +import java.io.IOException; +import java.io.InputStream; +import java.security.InvalidKeyException; +import java.security.NoSuchAlgorithmException; +import java.util.*; + +import io.minio.DownloadObjectArgs; +import io.minio.MinioClient; +import io.minio.Result; +import io.minio.errors.InvalidBucketNameException; +import io.minio.errors.MinioException; +import io.minio.messages.Bucket; +import io.minio.messages.Item; +import org.apache.camel.AsyncCallback; +import org.apache.camel.Exchange; +import org.apache.camel.ExtendedExchange; +import org.apache.camel.NoFactoryAvailableException; +import org.apache.camel.Processor; +import org.apache.camel.spi.Synchronization; +import org.apache.camel.support.ScheduledBatchPollingConsumer; +import org.apache.camel.util.CastUtils; +import org.apache.camel.util.ObjectHelper; +import org.apache.camel.util.URISupport; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A Consumer of messages from the Minio Storage Service. + */ +public class MinioConsumer extends ScheduledBatchPollingConsumer { + + private static final Logger LOG = LoggerFactory.getLogger(MinioConsumer.class); + + private Iterator<Result<Item>> marker; + private transient String minioConsumerToString; + + public MinioConsumer(MinioEndpoint endpoint, Processor processor) throws NoFactoryAvailableException { + super(endpoint, processor); + } + + @Override + protected int poll() throws Exception { + // must reset for each poll + shutdownRunningTask = null; + pendingExchanges = 0; + + assert getConfiguration().getBucketName() != null; Review comment: Maybe you should avoid using `assert`. It is not enabled by default. It would be better to handle that with `if` condition. ########## File path: components/camel-minio/src/main/java/org/apache/camel/component/minio/MinioEndpoint.java ########## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.minio; + +import java.io.*; +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; +import java.util.Map; + +import io.minio.GetObjectTagsArgs; +import io.minio.MakeBucketArgs; +import io.minio.MinioClient; +import io.minio.errors.InvalidBucketNameException; +import io.minio.messages.Tags; +import jdk.internal.org.jline.utils.Log; +import org.apache.camel.Category; +import org.apache.camel.Component; +import org.apache.camel.Consumer; +import org.apache.camel.Exchange; +import org.apache.camel.ExchangePattern; +import org.apache.camel.ExtendedExchange; +import org.apache.camel.Message; +import org.apache.camel.Processor; +import org.apache.camel.Producer; +import org.apache.camel.component.minio.client.MinioClientFactory; +import org.apache.camel.spi.Metadata; +import org.apache.camel.spi.UriEndpoint; +import org.apache.camel.spi.UriParam; +import org.apache.camel.spi.UriPath; +import org.apache.camel.support.ScheduledPollEndpoint; +import org.apache.camel.support.SynchronizationAdapter; +import org.apache.camel.util.ObjectHelper; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Store and retrie objects from Minio Storage Service using Minio SDK. Review comment: Typo: retrieve ########## File path: components/camel-minio/src/main/java/org/apache/camel/component/minio/MinioConsumer.java ########## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.minio; + +import java.io.IOException; +import java.io.InputStream; +import java.security.InvalidKeyException; +import java.security.NoSuchAlgorithmException; +import java.util.*; + +import io.minio.DownloadObjectArgs; +import io.minio.MinioClient; +import io.minio.Result; +import io.minio.errors.InvalidBucketNameException; +import io.minio.errors.MinioException; +import io.minio.messages.Bucket; +import io.minio.messages.Item; +import org.apache.camel.AsyncCallback; +import org.apache.camel.Exchange; +import org.apache.camel.ExtendedExchange; +import org.apache.camel.NoFactoryAvailableException; +import org.apache.camel.Processor; +import org.apache.camel.spi.Synchronization; +import org.apache.camel.support.ScheduledBatchPollingConsumer; +import org.apache.camel.util.CastUtils; +import org.apache.camel.util.ObjectHelper; +import org.apache.camel.util.URISupport; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A Consumer of messages from the Minio Storage Service. + */ +public class MinioConsumer extends ScheduledBatchPollingConsumer { + + private static final Logger LOG = LoggerFactory.getLogger(MinioConsumer.class); + + private Iterator<Result<Item>> marker; + private transient String minioConsumerToString; + + public MinioConsumer(MinioEndpoint endpoint, Processor processor) throws NoFactoryAvailableException { + super(endpoint, processor); + } + + @Override + protected int poll() throws Exception { + // must reset for each poll + shutdownRunningTask = null; + pendingExchanges = 0; + + assert getConfiguration().getBucketName() != null; + String bucketName = getConfiguration().getBucketName(); + MinioClient minioClient = getMinioClient(); + String objectName = getConfiguration().getObjectName(); + InputStream minioObject = null; + Queue<Exchange> exchanges = null; + + if (bucketExists(minioClient, bucketName)) { + LOG.trace("Bucket {} exists", bucketName); + } else { + throw new InvalidBucketNameException("Bucket {} does not exists", bucketName); + } + + if (objectName != null) { + LOG.trace("Getting object in bucket {} with object name {}...", bucketName, objectName); + + try { + minioObject = getObject(bucketName, minioClient, objectName); + if (minioObject != null) { + exchanges = createExchanges(minioObject, objectName); + } + + } catch (Throwable e) { + LOG.warn("Failed to get object in bucket {} with object name {}, Error message {}", bucketName, objectName, e.getMessage()); + throw e; + + } finally { + //must be closed after use to release network resources. + try { + assert minioObject != null; + minioObject.close(); Review comment: Maybe [try-with-resources](https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html) could be used here. It would be nice to reduce nesting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
