bedlaj commented on pull request #3934: URL: https://github.com/apache/camel/pull/3934#issuecomment-650567476
Good start. Since this is draft, i will give a few suggestions, instead of full review. - Please avoid using lombok there are many good reasons to not using that. - Use jsoup and joda-time versions provided in parent pom. - In final version, there must be all remote http calls removed, instead setup mock or use testcontainers. - Thread.sleep in tests can be replaced with proper assertions. - Never use `assert` keyword in unit tests. - Do not use `@author` annotations in javadoc. - Is safe to assume that response will be always UTF-8 and in Zulu timezone? - Headers should follow CamelOaimph* pattern, insead of oaimph.* - Endpoint class should contain some field annotated with `@UriPath` - For consumer use AsyncCallback in AsyncProcessor instead of try-catch-finally (Look eg to WsConsumer for inspiration) - Is `build-helper-maven-plugin` required? I dont see any custom generated (re)sources. And some obvious things, which I believe you know about. - Checkstyle violations - Missing licence headers - Logging to console instead of file - Missing Jira issue - Commented out UriEndpoint annotation (+category attribute) - Full build needed, to generate endpoint-dsl, component-dsl, ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
