ppalaga commented on a change in pull request #998: URL: https://github.com/apache/camel-quarkus/pull/998#discussion_r441597268
########## File path: extensions/tika/runtime/src/main/doc/limitations.adoc ########## @@ -0,0 +1,20 @@ +Parameters `tikaConfig` and `tikaConfigUri` are not available in quarkus camel tika extension. Configuration +can be changed only via `application.properties`. + +While you can use any of the available Tika parsers in JVM mode (https://tika.apache.org/[Apache Tika]), +only several Tika parses are supported in native mode. See https://quarkus.io/guides/tika[QUARKUS - USING APACHE TIKA]. + +In order to work in native mode, some properties should be set: + +* `quarkus.tika.parsers` +* optionally `quarkus.tika.parser.*` + +Example of `application.properties` follows : +[source,properties] +---- +quarkus.tika.parsers = pdf,odf,office +quarkus.tika.parser.office = org.apache.tika.parser.microsoft.OfficeParser +---- Review comment: My understanding is that using `quarkus.tika.parsers` is recommended (not required) to reduce the application memory and native executable sizes. So we should perhaps also formulate it like that. It is not clear to me whether each abbreviation used in `quarkus.tika.parsers` needs to be defined in `quarkus.tika.parser.my-abbrev` ? Or are there some well known abbreviations? ########## File path: extensions/tika/runtime/src/main/doc/limitations.adoc ########## @@ -0,0 +1,20 @@ +Parameters `tikaConfig` and `tikaConfigUri` are not available in quarkus camel tika extension. Configuration +can be changed only via `application.properties`. + +While you can use any of the available Tika parsers in JVM mode (https://tika.apache.org/[Apache Tika]), +only several Tika parses are supported in native mode. See https://quarkus.io/guides/tika[QUARKUS - USING APACHE TIKA]. + +In order to work in native mode, some properties should be set: + +* `quarkus.tika.parsers` +* optionally `quarkus.tika.parser.*` + +Example of `application.properties` follows : +[source,properties] +---- +quarkus.tika.parsers = pdf,odf,office +quarkus.tika.parser.office = org.apache.tika.parser.microsoft.OfficeParser +---- + +For more information about selecting parsers see https://quarkus.io/guides/tika[QUARKUS - USING APACHE TIKA] Review comment: ```suggestion For more information about selecting parsers see https://quarkus.io/guides/tika[Quarkus Tika guide] ``` ########## File path: extensions-support/xalan/runtime/src/main/java/org/apache/camel/quarkus/support/xalan/XalanTransformerFactory.java ########## @@ -110,4 +115,42 @@ public void setErrorListener(ErrorListener listener) { public ErrorListener getErrorListener() { return delegate.getErrorListener(); } + + private SAXTransformerFactory delegateAsSAXTransformerFactory() { + if (delegate instanceof SAXTransformerFactory) { + return (SAXTransformerFactory) delegate; + } + throw new IllegalArgumentException("Unsupported TransformerFactory feature " + SAXTransformerFactory.FEATURE); Review comment: I think it would be more effective to move this check to the constructor and change the type of the delegate field to SAXTransformerFactory thus eliminating the `delegateAsSAXTransformerFactory()` method. Given that we call `TransformerFactory.newInstance( "org.apache.xalan.xsltc.trax.TransformerFactoryImpl", ...)` we are quite safe to always get a SAXTransformerFactory ########## File path: extensions/tika/runtime/src/main/doc/limitations.adoc ########## @@ -0,0 +1,20 @@ +Parameters `tikaConfig` and `tikaConfigUri` are not available in quarkus camel tika extension. Configuration +can be changed only via `application.properties`. + +While you can use any of the available Tika parsers in JVM mode (https://tika.apache.org/[Apache Tika]), +only several Tika parses are supported in native mode. See https://quarkus.io/guides/tika[QUARKUS - USING APACHE TIKA]. Review comment: ```suggestion While you can use any of the available https://tika.apache.org/1.24.1/formats.html[Tika parsers] in JVM mode, only some of those are supported in native mode - see the https://quarkus.io/guides/tika[Quarkus Tika guide]. ``` ########## File path: extensions/tika/runtime/src/main/java/org/apache/camel/quarkus/component/tika/TikaRecorder.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.tika; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Collections; +import java.util.Set; + +import org.xml.sax.ContentHandler; +import org.xml.sax.SAXException; + +import io.quarkus.arc.runtime.BeanContainer; +import io.quarkus.runtime.RuntimeValue; +import io.quarkus.runtime.annotations.Recorder; +import io.quarkus.tika.TikaContent; +import io.quarkus.tika.TikaMetadata; +import io.quarkus.tika.TikaParser; +import io.quarkus.tika.runtime.TikaParserProducer; +import org.apache.camel.Component; +import org.apache.camel.Producer; +import org.apache.camel.component.tika.TikaComponent; +import org.apache.camel.component.tika.TikaConfiguration; +import org.apache.camel.component.tika.TikaEndpoint; +import org.apache.camel.component.tika.TikaProducer; +import org.apache.tika.exception.TikaException; +import org.apache.tika.metadata.Metadata; +import org.apache.tika.mime.MediaType; +import org.apache.tika.parser.ParseContext; +import org.apache.tika.parser.Parser; + +@Recorder +public class TikaRecorder { + + public RuntimeValue<TikaComponent> createTikaComponent(BeanContainer container) { + return new RuntimeValue<>(new QuarkusTikaComponent(container.instance(TikaParserProducer.class))); + } + + @org.apache.camel.spi.annotations.Component("tika") Review comment: Is this annotation required given that we produce a named bean above? https://github.com/apache/camel-quarkus/pull/998/files#diff-6af9bcae1d2af7449582ad99e6bdac3cR54 ########## File path: extensions/tika/runtime/src/main/java/org/apache/camel/quarkus/component/tika/TikaRecorder.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.tika; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Collections; +import java.util.Set; + +import org.xml.sax.ContentHandler; +import org.xml.sax.SAXException; + +import io.quarkus.arc.runtime.BeanContainer; +import io.quarkus.runtime.RuntimeValue; +import io.quarkus.runtime.annotations.Recorder; +import io.quarkus.tika.TikaContent; +import io.quarkus.tika.TikaMetadata; +import io.quarkus.tika.TikaParser; +import io.quarkus.tika.runtime.TikaParserProducer; +import org.apache.camel.Component; +import org.apache.camel.Producer; +import org.apache.camel.component.tika.TikaComponent; +import org.apache.camel.component.tika.TikaConfiguration; +import org.apache.camel.component.tika.TikaEndpoint; +import org.apache.camel.component.tika.TikaProducer; +import org.apache.tika.exception.TikaException; +import org.apache.tika.metadata.Metadata; +import org.apache.tika.mime.MediaType; +import org.apache.tika.parser.ParseContext; +import org.apache.tika.parser.Parser; + +@Recorder +public class TikaRecorder { + + public RuntimeValue<TikaComponent> createTikaComponent(BeanContainer container) { + return new RuntimeValue<>(new QuarkusTikaComponent(container.instance(TikaParserProducer.class))); + } + + @org.apache.camel.spi.annotations.Component("tika") + static class QuarkusTikaComponent extends TikaComponent { + + private final TikaParserProducer tikaParserProducer; + + public QuarkusTikaComponent(TikaParserProducer tikaParserProducer) { Review comment: This is acceptable for now, but as a next step, could we perhaps define some sort of TikaParserProducer interface in Camel and have it there in the Camel Tika component and producer, so that we do not have to subclass here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
