omarsmak commented on a change in pull request #3917:
URL: https://github.com/apache/camel/pull/3917#discussion_r441365350
##########
File path:
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Endpoint.java
##########
@@ -36,14 +36,20 @@
import org.apache.camel.util.URISupport;
/**
- * Exchanges messages with an AS/400 system using data queues or program call.
+ * Exchanges messages with an AS/400 system using data queues, message queues,
or program call.
*/
@UriEndpoint(firstVersion = "1.5.0", scheme = "jt400", title = "JT400", syntax
= "jt400:userID:password/systemName/objectPath.type", category =
{Category.MESSAGING})
public class Jt400Endpoint extends ScheduledPollEndpoint implements
MultipleConsumersSupport {
public static final String KEY = "KEY";
public static final String SENDER_INFORMATION = "SENDER_INFORMATION";
+ // Used only for message queue support
+ public static final String MESSAGE_ID = "jt400.MESSAGE_ID";
Review comment:
These are the Camel headers isn't? I think it would make sense to have
the headers with `Camel` prefix in order to standardize with other components
as well, e.g: `CamelJt400MessageID`.
Also, it would make sense to place the constants into a singleton class to
ease the usability for users.
Example from [recent
component](https://github.com/apache/camel/blob/master/components/camel-azure-storage-queue/src/main/java/org/apache/camel/component/azure/storage/queue/QueueConstants.java).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
