[GitHub] [camel-website] zregvart commented on a change in pull request #396: CAMEL-15161: Modify the design for functionality section on frontpage

[GitBox]

zregvart commented on a change in pull request #396:
URL: https://github.com/apache/camel-website/pull/396#discussion_r441089100



##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -197,12 +197,14 @@ section.frontpage h2 {
 }
 
 .frontpage .box {
-  flex: 50%;
-  padding: 1.2rem 0;
+  flex: 33%;
+  flex-direction: column;
+  margin: 1rem;
+  padding: 1.2rem 0.75rem;
+  border: 1px solid #e1e1e1;

Review comment:
       We need to use variables
   
   ```suggestion
     border: 1px solid var(--color-smoke-90);
   ```

##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -117,7 +117,7 @@
   /* static */
   --static-margin: 0 auto;
   /* frontpage */
-  --frontpage-max-width: calc(1140 / var(--rem-base) * 1rem);
+  --frontpage-max-width: calc(1350 / var(--rem-base) * 1rem);

Review comment:
       With the Antora rebase we have 1366px as width, would be good to be 
consistent here.
   ```suggestion
     --frontpage-max-width: calc(1366 / var(--rem-base) * 1rem);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org