[GitHub] [camel] djencks commented on pull request #3912: Re-style the javascript for gulpfile

[GitBox]

djencks commented on pull request #3912:
URL: https://github.com/apache/camel/pull/3912#issuecomment-643772120


   Thanks for looking into this, this is definitely an improvement.
   
   I'm used to and prefer _no_ semicolon line ends.
   
   I'm used to projects enforcing style with ESLint and an .eslintrc file, and 
providing lint and lint-fix scripts in package.json.
   
   The .eslintrc files I use are
   ```
   {
     "extends": "standard",
     "rules": {
       "arrow-parens": ["error", "always"],
       "comma-dangle": ["error", {
         "arrays": "always-multiline",
         "objects": "always-multiline",
         "imports": "always-multiline",
         "exports": "always-multiline"
       }],
       "max-len": ["error", {
         "code": 120,
         "ignoreStrings": true,
         "ignoreUrls": true,
         "ignoreTemplateLiterals": true
       }],
       "spaced-comment": "off"
     }
   }
   ```
   
   and the bits of package.json
   
   ```
     "scripts": {
       "lint": "eslint lib/**/**.js test/**/**.js",
       "lint-fix": "eslint lib/**/**.js test/**/**.js --fix"
     },
     "devDependencies": {
       "eslint": "~6.7",
       "eslint-config-standard": "~14.1",
       "eslint-plugin-import": "~2.19",
       "eslint-plugin-node": "~10.0",
       "eslint-plugin-promise": "~4.2",
       "eslint-plugin-standard": "~4.0",
       "prettier-eslint-cli": "~5.0"
     }
   ```
   
   I'm not sure if all the dependencies are needed.
   
   What do you think about adding these scripts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org