orpiske commented on a change in pull request #272:
URL:
https://github.com/apache/camel-kafka-connector/pull/272#discussion_r439293005
##########
File path:
tests/itests-common/src/test/java/org/apache/camel/kafkaconnector/common/services/kafka/KafkaService.java
##########
@@ -18,15 +18,13 @@
package org.apache.camel.kafkaconnector.common.services.kafka;
import org.junit.jupiter.api.extension.AfterAllCallback;
-import org.junit.jupiter.api.extension.AfterTestExecutionCallback;
import org.junit.jupiter.api.extension.BeforeAllCallback;
-import org.junit.jupiter.api.extension.BeforeTestExecutionCallback;
import org.junit.jupiter.api.extension.ExtensionContext;
/**
* Provides an interface for any type of Kafka service: remote instances,
local container, etc
*/
-public interface KafkaService extends BeforeAllCallback,
BeforeTestExecutionCallback, AfterAllCallback, AfterTestExecutionCallback {
Review comment:
Out of curiosity: did you notice any problems w/ loading the plugins on
the Connect runtime? One of the reasons I had to change this on #262 was
because keeping the connect runtime instance up and just bouncing it after the
whole module was done, leads to a leak on the runtime (which caused the first
version of the PR to fail). Bouncing both solved the issue (at the expense of a
longer test time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
