oscerd commented on a change in pull request #3897: URL: https://github.com/apache/camel/pull/3897#discussion_r436470452
########## File path: components/camel-minio/ReadMe.txt ########## @@ -0,0 +1,33 @@ + +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> + +Camel Component Project +======================= + +This project is a template of a Camel component. + +To build this project use + + mvn install + +For more help see the Apache Camel documentation: + + http://camel.apache.org/writing-components.html + Review comment: This is not needed. You could remove this file. ########## File path: components/camel-minio/pom.xml ########## @@ -0,0 +1,140 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <artifactId>components</artifactId> + <groupId>org.apache.camel</groupId> + <version>3.4.0-SNAPSHOT</version> + </parent> + + <artifactId>camel-minio</artifactId> + <packaging>jar</packaging> + + <name>Camel :: MinIO</name> + <description>A Camel MinIO cloud storage server Component </description> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> + </properties> + + <dependencyManagement> + <dependencies> + <!-- Camel BOM --> + <dependency> + <groupId>org.apache.camel</groupId> Review comment: No need for the camel-bom here. Take as example the other components in the components folder. ########## File path: components/pom.xml ########## @@ -382,6 +382,7 @@ <module>camel-zipkin</module> <module>camel-zookeeper-master</module> <module>camel-zookeeper</module> + <module>camel-minio</module> Review comment: Please add the component in the correct order. ########## File path: components/camel-minio/src/main/java/org/apache/camel/EventBusHelper.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel; + +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.function.Consumer; + +/** + * Used for demonstrations purpose to simulate some external system event bus/broker, where messages are sent to, and + * this component can consume from. + */ +public class EventBusHelper { Review comment: This class can be removed. ########## File path: components/camel-minio/src/main/java/org/apache/camel/MinIOConsumer.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel; + +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.RuntimeCamelException; +import org.apache.camel.support.DefaultConsumer; + +import java.util.concurrent.ExecutorService; + +public class MinIOConsumer extends DefaultConsumer { + private final MinIOEndpoint endpoint; + private final EventBusHelper eventBusHelper; + + private ExecutorService executorService; + + public MinIOConsumer(MinIOEndpoint endpoint, Processor processor) { + super(endpoint, processor); + this.endpoint = endpoint; + eventBusHelper = EventBusHelper.getInstance(); Review comment: Remove the eventBusHelper, except it is something really useful to the basic feature of component, but I don't think so. ########## File path: components/camel-minio/src/main/java/org/apache/camel/MinIOComponent.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel; + +import java.util.Map; + +import org.apache.camel.CamelContext; +import org.apache.camel.Endpoint; + +import org.apache.camel.support.DefaultComponent; + +@org.apache.camel.spi.annotations.Component("MinIO") Review comment: You can use directly Component annotation without the whole package. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
