jonchase commented on a change in pull request #3891: URL: https://github.com/apache/camel/pull/3891#discussion_r436255966
########## File path: components/camel-aws2-athena/src/main/java/org/apache/camel/component/aws2/athena/Athena2Configuration.java ########## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.aws2.athena; + +import org.apache.camel.RuntimeCamelException; +import org.apache.camel.spi.Metadata; +import org.apache.camel.spi.UriParam; +import org.apache.camel.spi.UriParams; +import org.apache.camel.spi.UriPath; + +import software.amazon.awssdk.core.Protocol; +import software.amazon.awssdk.services.athena.AthenaClient; +import software.amazon.awssdk.services.athena.model.EncryptionOption; +import software.amazon.awssdk.services.athena.paginators.GetQueryResultsIterable; + +@UriParams +public class Athena2Configuration implements Cloneable { + + @UriPath(description = "Logical name") + @Metadata(required = true) + private String label; Review comment: Happy to add the getter/setter here if you feel it belongs. For context, I copy/pasted the code from the aws2-ec2 component, which uses a similar pattern, and it did not have the getters/setters. If I should add them here, should I open a small PR to add them to the EC2 component as well? For reference, the URI format is `aws2-athena://label[?options]`. Would it be a normal/desirable thing for the label part of the URI to get changed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
