djencks commented on pull request #3860: URL: https://github.com/apache/camel/pull/3860#issuecomment-635137587
The code modifications look good, but I didn't try building it. A couple of minor comments: - it might be worth reading each file only once and extracting both parent and child attributes at once, returning them in an object or array. - I'm not sure if deleting the AWS, AWS2 and google pages is a good idea. It might be better to turn them into real summary pages, at least with an index list. With this I think we'd be set for generating an index list on the summary pages. Would you like to do that or would you prefer I do it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org