zregvart commented on a change in pull request #340:
URL: https://github.com/apache/camel-website/pull/340#discussion_r412887551
##########
File path: antora-ui-camel/src/js/vendor/algoliasearch.bundle.js
##########
@@ -46,7 +46,12 @@
const data = hits.reduce((data, hit) => {
const d = {}
d.url = hit.url
- d.breadcrumbs = Object.values(hit.hierarchy).slice(1).filter((lvl)
=> lvl !== null).join(' » ')
+ var breadcrumbs =
Object.values(hit.hierarchy).slice(1).filter((lvl) => lvl !== null).join('
» ')
Review comment:
What I understood was that the discussion was about including lvl0 and
comparing how the default Algolia UI handles similar case.
I still think this PR improves the search, so we can merge it.
There is a lot of work on the search left to do. I'll create a JIRA issue to
open the discussion on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
