aashnajena commented on a change in pull request #340: Fix issues with search
results
URL: https://github.com/apache/camel-website/pull/340#discussion_r410863410
##########
File path: antora-ui-camel/src/js/vendor/algoliasearch.bundle.js
##########
@@ -46,7 +46,12 @@
const data = hits.reduce((data, hit) => {
const d = {}
d.url = hit.url
- d.breadcrumbs = Object.values(hit.hierarchy).slice(1).filter((lvl)
=> lvl !== null).join(' » ')
+ var breadcrumbs =
Object.values(hit.hierarchy).slice(1).filter((lvl) => lvl !== null).join('
» ')
Review comment:
I'm not very sure about how to check that. What I tried doing was test their
live demo. Here, if I search for a brand itself, they only show the matching
products (but in this example each product has the brand name in its title)
Also, the idea of displaying number of matches per section seems good to me.
Can we include that in our website?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
