ppalaga commented on a change in pull request #1093: Introducing an AWS2
support extension
URL: https://github.com/apache/camel-quarkus/pull/1093#discussion_r408972691
##########
File path:
extensions/aws2-s3/deployment/src/main/java/org/apache/camel/quarkus/component/aws2/s3/deployment/Aws2S3Processor.java
##########
@@ -89,12 +89,6 @@ void client(BeanRegistrationPhaseBuildItem
beanRegistrationPhase,
BuildProducer<NativeImageProxyDefinitionBuildItem>
proxyDefinition) {
checkClasspath(APACHE_HTTP_SERVICE, "apache-client");
- //Register Apache client as sync client
- proxyDefinition.produce(
- new
NativeImageProxyDefinitionBuildItem("org.apache.http.conn.HttpClientConnectionManager",
- "org.apache.http.pool.ConnPoolControl",
-
"software.amazon.awssdk.http.apache.internal.conn.Wrapped"));
-
serviceProvider.produce(new
ServiceProviderBuildItem(SdkHttpService.class.getName(), APACHE_HTTP_SERVICE));
Review comment:
Similar as above: Isn't this serviceProvider also a good candidate to move
to the new support extension?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
