ppalaga commented on a change in pull request #1088: Lightweight context without init / start phases URL: https://github.com/apache/camel-quarkus/pull/1088#discussion_r408840383
########## File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ########## @@ -525,12 +533,20 @@ UnremovableBeanBuildItem unremovableRoutesBuilders() { } @Overridable - @Record(value = ExecutionTime.RUNTIME_INIT, optional = true) + @Record(value = ExecutionTime.STATIC_INIT, optional = true) @BuildStep(onlyIf = Flags.MainEnabled.class) CamelReactiveExecutorBuildItem reactiveExecutor(CamelMainRecorder recorder) { return new CamelReactiveExecutorBuildItem(recorder.createReactiveExecutor()); } + @Overridable + @Record(value = ExecutionTime.RUNTIME_INIT, optional = true) + @BuildStep(onlyIf = Flags.MainEnabled.class) + CamelInitializedReactiveExecutorBuildItem initReactiveExecutor( + CamelMainRecorder recorder, CamelReactiveExecutorBuildItem executor) { Review comment: Are the `recorder` param and `@Record` annotation required? If so, could you please add a comment explaining why? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services