aashnajena opened a new pull request #340: Fix issues with search results
URL: https://github.com/apache/camel-website/pull/340
 
 
   I noticed a couple of issues :
   
   1) "Nothing found" box is very cramped.
   
![no_results_old](https://user-images.githubusercontent.com/32356795/78793179-a9ab7a00-79cf-11ea-9e96-3cf0c286c6f0.png)
   
   Fix:
   
![no_results_new](https://user-images.githubusercontent.com/32356795/78793163-a4e6c600-79cf-11ea-8f51-3182122d21ae.png)
   
   2) I noticed there's excess space in some search results. For example, try 
searching for "Book", or "Camel" or "Article". I realised that there were some 
empty search results being displayed here. As shown in screenshots below, the 
URL for them exists, but heading & summary doesn't, because these are actually 
"section names" which match with the query. 
   
   
![search_results_fix](https://user-images.githubusercontent.com/32356795/78793422-04dd6c80-79d0-11ea-80c3-f66a849fcedc.png)
   
   
![search_example_2](https://user-images.githubusercontent.com/32356795/78793405-ff802200-79cf-11ea-8cf9-fca40616c5ac.png)
   
   Fix : I thought of two ways we can go about it - either we don't display 
these empty results, or we show the section names in their place. Second one 
seemed apt to me, since all such "missing content" cases that I could find were 
links to sections. 
   
   
![search-fix](https://user-images.githubusercontent.com/32356795/78793834-96e57500-79d0-11ea-9e57-adf06b347c54.png)
    
    Please let me know if we would prefer to fix this in some other way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to