zregvart commented on a change in pull request #327: Search-Cancel Button
position fixes in the search box
URL: https://github.com/apache/camel-website/pull/327#discussion_r405482574
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -416,9 +416,9 @@ body {
#search-cancel {
position: relative;
- bottom: 1.4rem;
- left: 10.6rem;
- height: 1.1rem;
+ bottom: calc(50% - var(--body-font-size--desktop) / 7.5);
+ left: calc(100% - var(--body-font-size--desktop) / 0.9);
Review comment:
@psingh587 could be that there isn't one that we explicitly have captured in
a variable. I _think_ we could compute this from the height the icon subtracted
from of the input box and then divide that in half to get equal parts above and
below the icon. We could also play with padding/margins so we position at 50%
and padding/margin makes sure it's centred. There's no need to make this more
complicated than it is though. If you're okay with how it is right now I think
we can merge this as it does fix a problem we have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
