ppalaga commented on a change in pull request #1050: InfluxDB native support
#1036
URL: https://github.com/apache/camel-quarkus/pull/1050#discussion_r404937985
##########
File path:
extensions/influxdb/deployment/src/main/java/org/apache/camel/quarkus/component/influxdb/deployment/InfluxdbProcessor.java
##########
@@ -16,32 +16,27 @@
*/
package org.apache.camel.quarkus.component.influxdb.deployment;
+import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
-import io.quarkus.deployment.annotations.ExecutionTime;
-import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
import io.quarkus.deployment.builditem.FeatureBuildItem;
-import io.quarkus.deployment.pkg.steps.NativeBuild;
-import org.apache.camel.quarkus.core.JvmOnlyRecorder;
-import org.jboss.logging.Logger;
+import
io.quarkus.deployment.builditem.nativeimage.NativeImageProxyDefinitionBuildItem;
class InfluxdbProcessor {
- private static final Logger LOG =
Logger.getLogger(InfluxdbProcessor.class);
private static final String FEATURE = "camel-influxdb";
@BuildStep
- FeatureBuildItem feature() {
+ FeatureBuildItem feature(BuildProducer<ExtensionSslNativeSupportBuildItem>
extensionSslNativeSupport) {
+
+ // Indicates that this extension would like the SSL support to be
enabled
+ extensionSslNativeSupport.produce(new
ExtensionSslNativeSupportBuildItem(FEATURE));
+
Review comment:
I think `extensionSslNativeSupport.produce(new
ExtensionSslNativeSupportBuildItem(FEATURE));` deserves a separate `@BuildStep`
method. The code would be easier to follow that way.
@lburgazzoli would even say that all `*Native*BuildItem` s should be
produced in a separate `InfluxdbNativeProcessor` class. I do not find it
necessary as long as there is a just a few methods here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
