djencks commented on issue #317: Improve search results layout
URL: https://github.com/apache/camel-website/pull/317#issuecomment-609451882
 
 
   I strongly recommend NOT renaming the javascript files.  The camel Antora UI 
is derived from the Antora default UI, and one of the worst parts of the 
“Antora experience” is updating a UI from updates in the base default UI.  
Renaming files such as 05-nav-search.js would make this even harder.
   
   I suspect that it will be desirable to update the camel UI from the default 
soon, as the default UI has recently been getting some very nice features such 
as “on this page” TOC in the right sidebar.  I’d wait until Antora 2.3.0 is 
released though.
   
   > On Apr 5, 2020, at 4:28 AM, Aashna Jena <notificati...@github.com> wrote:
   > 
   > 
   > Added bold highlight for matched substrings (updated screenshot above) and 
fixed a minor typos. Also can we rename the js files? In all honesty, it took 
me a lot of time to realise that 05-nav-search.js is for the quick look-ups and 
algoliasearch.bundle.js is for header search.
   > 
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub 
<https://github.com/apache/camel-website/pull/317#issuecomment-609401484>, or 
unsubscribe 
<https://github.com/notifications/unsubscribe-auth/AAELDXS64PVDFX7CHNGPOB3RLBTOJANCNFSM4L7M2V7A>.
   > 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to