zregvart commented on a change in pull request #271: Fixes Wastage of screen real-estate on large displays URL: https://github.com/apache/camel-website/pull/271#discussion_r402903733
########## File path: antora-ui-camel/src/css/vars.css ########## @@ -131,9 +132,9 @@ --nav-panel-height--desktop: calc(var(--nav-height--desktop) - var(--drawer-height)); --nav-width: calc(270 / var(--rem-base) * 1rem); --doc-max-width: calc(720 / var(--rem-base) * 1rem); - --doc-max-width--desktop: calc(828 / var(--rem-base) * 1rem); + --doc-max-width--desktop: calc(828 * var(--vw-base--desktop) * 1vw); --static-max-width: calc(720 / var(--rem-base) * 1rem); - --static-max-width--desktop: calc(1140 / var(--rem-base) * 1rem); + --static-max-width--desktop: calc(1140 * var(--vw-base--desktop) * 1vw); Review comment: This change in formulas seems arbitrary, what we had matches this logic: we want to have the width in vw. So to do that we divide the number in px by the base rem size, giving us the number of rems in a number of pixels, when we multiply that by 1 rem to get resulting the measure in vw. You seem to multiply a number by a percentage and then multiply that by a device width varying unit. Can you explain the logic behind the changed formula? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
