zregvart commented on a change in pull request #298: Pulling data from json apis URL: https://github.com/apache/camel-website/pull/298#discussion_r401469832
########## File path: layouts/shortcodes/contributors.html ########## @@ -0,0 +1,40 @@ + +<table class="tableblock stretch"> + <thead> + <tr> + <th>Avatar</th> + <th>Name</th> + <th>Organization</th> + </tr> + </thead> + <tbody> + {{ range $page_count := (seq 10) }} + {{ $page := string $page_count }} + {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }} + {{ range $git_contributors }} + {{ if .url }} Review comment: Nicer way would be to use `with` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services