AemieJ commented on issue #985: add the auto-generated tabular form for 
examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604913088
 
 
   > > > @AemieJ the commit message says auto-generated, but where is the code 
that generates the table in the commit?
   > > 
   > > 
   > > Isn't it the syntax of AsicDoctor that you write the table data in 
particular syntax and it will provide you with a responsive table design?
   > 
   > Sorry, there is probably some mismatch between you and me in how we 
understand the term "auto-generated". For me, auto-generated text is an output 
of some computer program. The list of extensions 
https://camel.apache.org/camel-quarkus/latest/list-of-camel-quarkus-extensions.html
 is auto-generated in this sense by the maven plugin located in our repo: 
https://github.com/apache/camel-quarkus/blob/master/tooling/package-maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateDocExtensionsListMojo.java
   > This approach has the advantage that anytime a new extension is added the 
list is updated automatically.
   > 
   > I thought, you were doing something similar for the list of examples. If 
this was not your aim, I am fine with that, the change is an improvement 
against the previous state. We do not add new examples that often, so the list 
can be updated manually. But please remove the word `auto-generated` from the 
commit message and ideally squash your commits.
   
   Alright, I have currently made a new PR with a different commit. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to