zregvart commented on a change in pull request #210: Feature Avatar on Blog
Posts
URL: https://github.com/apache/camel-website/pull/210#discussion_r392679977
##########
File path: layouts/blog/post.html
##########
@@ -9,8 +9,24 @@ <h1><a href="{{.Page.Permalink}}">{{ .Title }}</a></h1>
<div class="post">
<aside>
<div class="summary">{{ .Params.preview }}</div>
- <time itemprop="published" datetime="{{ dateFormat "2006-01-02"
.PublishDate }}" title="{{ dateFormat "Monday, January 2, 2006" .PublishDate
}}">{{ dateFormat "January 2, 2006" .PublishDate }}</time>
- <p>by <span rel="author">{{ .Params.author }}</span></p>
+ <div class="info">
+ {{ if .Params.github_handle }}
+ <div class="post-avatar">
+ {{ $urlPre := "https://api.github.com"; }}
+ {{ $gist := getJSON $urlPre "/users/"
.Params.github_handle }}
+ {{ with $gist }}
Review comment:
Not sure there's a need for the `with` block here, it encompasses only one
element
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
