favourori commented on a change in pull request #189: opening foreign links in
new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390816817
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
+ <a class="navbar-item" href="{{ .URL | relURL
}}" target="_blank" rel="noopener">{{ .Name }}</a>
Review comment:
Great. Will fix that today. Thanks for the pointers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
