zregvart commented on a change in pull request #163: Pr/algolia search
URL: https://github.com/apache/camel-website/pull/163#discussion_r386903298
##########
File path: antora-ui-camel/src/partials/footer-scripts.hbs
##########
@@ -1,5 +1,6 @@
<script src="{{uiRootPath}}{{asset 'js/site.js'}}"></script>
<script async src="{{uiRootPath}}{{asset 'js/vendor/highlight.js'}}"></script>
<script async src="{{uiRootPath}}{{asset
'js/vendor/svg4everybody.js'}}"></script>
+<script async
src="https://cdn.jsdelivr.net/npm/algoliasearch@4/dist/algoliasearch-lite.umd.js";></script>
Review comment:
You need to copy the file to the vendor directory, the Antora UI build is
not using the dependencies declared in package.json. The idea of vendoring
dependencies is that we copy the dependency that we use into our own source
tree and not pull it in through any dependency management (such as npm or yarn).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
