ppalaga commented on issue #699: Remove UnbannedReflectiveBuildItem + policy 
extension ?
URL: https://github.com/apache/camel-quarkus/issues/699#issuecomment-584730522
 
 
   I am sorry for the inconvenience, but I still think that registering a class 
for reflection that belongs to a well known group that is expected not to need 
it, should not go without checking it properly. 
   
   Speaking for me, I do not feel able to eval during the review by pure sight 
whether some Camel class has some specific annotation. I think the policy does 
some useful work there. If we really want to tackle this, we should keep the 
policy.
   
   Going through tens of extensions manually afterwards to check whether we 
register for reflection only what is necessary is a lot of work, that I did 
twice and I would not wish anybody to that again.
   
   However, if we actually do not have the ambition to do this properly, I 
won't be against removing the policy.
   
   By no means this inconvenience can impact Camel Quarkus application 
developers unless they consciously depend on the policy extension. This is only 
the case in our integration tests. Failing is the right thing to do there 
because what does not fail the build gets ignored.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to