ppalaga commented on a change in pull request #678: camel-fhir record FHIR context instead of creating it at runtime. Onl… URL: https://github.com/apache/camel-quarkus/pull/678#discussion_r376973276
########## File path: extensions/fhir/deployment/src/main/java/org/apache/camel/quarkus/component/fhir/deployment/dstu2/Dstu2PropertiesBuildItem.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.fhir.deployment.dstu2; + +import java.util.Properties; + +import io.quarkus.builder.item.SimpleBuildItem; + +public final class Dstu2PropertiesBuildItem extends SimpleBuildItem { + + private final Properties properties; + + public Dstu2PropertiesBuildItem(Properties properties) { + this.properties = properties; + } + + public Properties getProperties() { + return properties; Review comment: Same as above: BuildItems should not expose mutable collections because they are consumed from concurrent threads. Mutability does not seem to be required here. Making the properties immutable would simplify the reasoning about the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
