ppalaga commented on a change in pull request #634: Run native tests with
GitHub Actions
URL: https://github.com/apache/camel-quarkus/pull/634#discussion_r369544125
##########
File path: .github/workflows/pr-validate.yml
##########
@@ -31,4 +35,10 @@ jobs:
with:
java-version: 1.8
- name: mvn package
- run: export LANG=en_US && ./mvnw -fae -B
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
clean package -Pcheck-format -DskipTests
+ run: |
+ ./mvnw -fae -B \
+
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
\
+ -DskipTests \
+ -Pcheck-format \
+ clean package
Review comment:
Not sure what is the exact idea behind `pr-validate.yml` but if we just want
to check the code style, licenses, etc. we could perhaps use some earlier phase
than `package`, e.g. `process-sources`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
