ppalaga commented on issue #599: Produce NativeImageEnableAllCharsetsBuildItem where appropriate URL: https://github.com/apache/camel-quarkus/issues/599#issuecomment-576292100 Thinking of this again, the advantages of producing NativeImageEnableAllCharsetsBuildItem by AHC, HTTP and other extensions would be the following: * The JVM mode and native mode would behave more consistently. * The behavior probably wanted by the most users would be enabled by default. An apparent disadvantage would be that the application developer might know that his app is never going to need any encoding beyond the set available by default. This would be the case when the developer has both the client and server under his control. Always producing NativeImageEnableAllCharsetsBuildItem would just make the application unnecessarily bigger. I am not sure if setting `quarkus.native.enable-all-charsets = false` in the application.properties overrides our default. Even if it does, it would be a pain to document. We'd have to write something like > If you have AHC in your CP, the default of quarkus.native.enable-all-charsets is not false like with vanilla Quarkus, but true. If you want to override the override, use quarkus.native.enable-all-charsets = false Maybe to get best of both worlds, we could have our own per-extension props, e.g. `quarkus.camel.ahc.enable-all-charsets` with default true. It would trigger NativeImageEnableAllCharsetsBuildItem only if it the value is true. So `quarkus.camel.ahc.enable-all-charsets = false` would work reliably for those few users who want (and know how) to fine tune their app. Does anybody have an opinion on this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
