ppalaga edited a comment on issue #482: Fix #476 List itests in an XML file for 
the Quarkus platform
URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559420070
 
 
   Yes, potential merge conflicts in the XML file would be nice to avoid. 
   
   The main motivation for me to keep the file in Git for now is that we have 
some irregularities in the `integration-tests` directory and the selection done 
by the plugin may get broken in the future. Having a chance to spot malign 
changes during the PR review could prevent that. - That's actually a sign that 
we should try to find a mechanism for exporting the tests that would be more 
robust than the current path matching. I vote for merging this PR as is and 
continue the discussion withing 
https://github.com/apache/camel-quarkus/issues/413 . Either the selection could 
work based on properties in the test POMs (the irregularities in main an core 
are still there) as you proposed or maybe we could put the aggregated tests 
into a new directory where we'd keep a strictly flat layout (so that the path 
matching would be less likely to break).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to