This is an automated email from the ASF dual-hosted git repository. aldettinger pushed a commit to branch CAMEL-13965 in repository https://gitbox.apache.org/repos/asf/camel.git
commit ae2dff6aa05d44166f32299276055197e98c3333 Author: aldettinger <aldettin...@gmail.com> AuthorDate: Fri Oct 25 17:24:00 2019 +0200 CAMEL-14084: Migrated remaining camel-consul tests to JUnit 5 --- components/camel-consul/pom.xml | 11 +++++------ .../cluster/ConsulClusteredRoutePolicyFactoryMain.java | 2 +- .../cluster/ConsulClusteredRoutePolicyFactoryTest.java | 14 ++++++++------ .../consul/cluster/ConsulClusteredRoutePolicyTest.java | 14 ++++++++------ .../camel/component/consul/cluster/ConsulMasterTest.java | 14 ++++++++------ parent/pom.xml | 5 +++++ 6 files changed, 35 insertions(+), 25 deletions(-) diff --git a/components/camel-consul/pom.xml b/components/camel-consul/pom.xml index 282cfed..2f1e666 100644 --- a/components/camel-consul/pom.xml +++ b/components/camel-consul/pom.xml @@ -59,11 +59,6 @@ <scope>test</scope> </dependency> <dependency> - <groupId>org.junit.vintage</groupId> - <artifactId>junit-vintage-engine</artifactId> - <scope>test</scope> - </dependency> - <dependency> <groupId>org.apache.camel</groupId> <artifactId>camel-mock</artifactId> <scope>test</scope> @@ -144,9 +139,13 @@ <artifactId>log4j-slf4j-impl</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.testcontainers</groupId> + <artifactId>junit-jupiter</artifactId> + <scope>test</scope> + </dependency> </dependencies> - <profiles> <profile> <id>consul-skip-tests</id> diff --git a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryMain.java b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryMain.java index 38259f6..e26c45d 100644 --- a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryMain.java +++ b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryMain.java @@ -50,7 +50,7 @@ public final class ConsulClusteredRoutePolicyFactoryMain { } }); - main.addRouteBuilder(new RouteBuilder() { + main.addRoutesBuilder(new RouteBuilder() { @Override public void configure() throws Exception { from("timer:clustered?delay=1s&period=1s") diff --git a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryTest.java b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryTest.java index 80d3f0c..eed51e3 100644 --- a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryTest.java +++ b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyFactoryTest.java @@ -31,16 +31,18 @@ import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.consul.ConsulTestSupport; import org.apache.camel.impl.DefaultCamelContext; import org.apache.camel.impl.cluster.ClusteredRoutePolicyFactory; -import org.junit.Assert; -import org.junit.ClassRule; -import org.junit.Test; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; +@Testcontainers public class ConsulClusteredRoutePolicyFactoryTest { - @ClassRule + @Container public static GenericContainer container = ConsulTestSupport.consulContainer(); private static final Logger LOGGER = LoggerFactory.getLogger(ConsulClusteredRoutePolicyFactoryTest.class); @@ -62,8 +64,8 @@ public class ConsulClusteredRoutePolicyFactoryTest { LATCH.await(1, TimeUnit.MINUTES); SCHEDULER.shutdownNow(); - Assert.assertEquals(CLIENTS.size(), RESULTS.size()); - Assert.assertTrue(RESULTS.containsAll(CLIENTS)); + Assertions.assertEquals(CLIENTS.size(), RESULTS.size()); + Assertions.assertTrue(RESULTS.containsAll(CLIENTS)); } // ************************************ diff --git a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyTest.java b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyTest.java index cb06bb6..a7867d3 100644 --- a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyTest.java +++ b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulClusteredRoutePolicyTest.java @@ -31,16 +31,18 @@ import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.consul.ConsulTestSupport; import org.apache.camel.impl.DefaultCamelContext; import org.apache.camel.impl.cluster.ClusteredRoutePolicy; -import org.junit.Assert; -import org.junit.ClassRule; -import org.junit.Test; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; +@Testcontainers public class ConsulClusteredRoutePolicyTest { - @ClassRule + @Container public static GenericContainer container = ConsulTestSupport.consulContainer(); private static final Logger LOGGER = LoggerFactory.getLogger(ConsulClusteredRoutePolicyTest.class); @@ -62,8 +64,8 @@ public class ConsulClusteredRoutePolicyTest { LATCH.await(1, TimeUnit.MINUTES); SCHEDULER.shutdownNow(); - Assert.assertEquals(CLIENTS.size(), RESULTS.size()); - Assert.assertTrue(RESULTS.containsAll(CLIENTS)); + Assertions.assertEquals(CLIENTS.size(), RESULTS.size()); + Assertions.assertTrue(RESULTS.containsAll(CLIENTS)); } // ************************************ diff --git a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulMasterTest.java b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulMasterTest.java index 90129b2..0a609ff 100644 --- a/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulMasterTest.java +++ b/components/camel-consul/src/test/java/org/apache/camel/component/consul/cluster/ConsulMasterTest.java @@ -30,16 +30,18 @@ import com.orbitz.consul.Consul; import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.consul.ConsulTestSupport; import org.apache.camel.impl.DefaultCamelContext; -import org.junit.Assert; -import org.junit.ClassRule; -import org.junit.Test; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; +@Testcontainers public class ConsulMasterTest { - @ClassRule + @Container public static GenericContainer container = ConsulTestSupport.consulContainer(); private static final Logger LOGGER = LoggerFactory.getLogger(ConsulMasterTest.class); @@ -61,8 +63,8 @@ public class ConsulMasterTest { LATCH.await(1, TimeUnit.MINUTES); SCHEDULER.shutdownNow(); - Assert.assertEquals(CLIENTS.size(), RESULTS.size()); - Assert.assertTrue(RESULTS.containsAll(CLIENTS)); + Assertions.assertEquals(CLIENTS.size(), RESULTS.size()); + Assertions.assertTrue(RESULTS.containsAll(CLIENTS)); } // ************************************ diff --git a/parent/pom.xml b/parent/pom.xml index 3af91aa..941517a 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -4870,6 +4870,11 @@ <artifactId>httpunit</artifactId> <version>${httpunit-version}</version> </dependency> + <dependency> + <groupId>org.testcontainers</groupId> + <artifactId>junit-jupiter</artifactId> + <version>${testcontainers-version}</version> + </dependency> <!-- default JPA support --> <dependency>