ppalaga commented on a change in pull request #243: Generate extension list 
readme file via tooling like we do at Apache Camel
URL: https://github.com/apache/camel-quarkus/pull/243#discussion_r332878075
 
 

 ##########
 File path: extensions/readme.adoc
 ##########
 @@ -0,0 +1,142 @@
+= Components
+
 
 Review comment:
   Not sure if this readme is produced to be included somewhere else where the 
context is clear, but here when the file is read as is, it is unclear what 
components are listed here. If they are supposed to be the components supported 
on Quarkus, then it should say so.
   
   Further, the versions in the Available From column seem to be Apache Camel 
versions and the document should say so, so that the reader does not end up 
with a false impression that those are Camel Quarkus versions.
   
   I like the format and we should consider re-using this data in 
https://github.com/apache/camel-quarkus/blob/master/docs/modules/ROOT/pages/list-of-camel-quarkus-extensions.adoc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to