This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch CAMEL-13870 in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/CAMEL-13870 by this push: new 61e02d6 CAMEL-13870: Fast property configuration of Camel endpoints. Work in progress. 61e02d6 is described below commit 61e02d6771ce9262a6bd054f6a470850594f10d0 Author: Claus Ibsen <claus.ib...@gmail.com> AuthorDate: Wed Aug 21 10:01:13 2019 +0200 CAMEL-13870: Fast property configuration of Camel endpoints. Work in progress. --- .../camel/component/smpp/SmppConfiguration.java | 2 +- .../component/smpp/SmppConnectionFactory.java | 4 +-- .../apache/camel/component/smpp/SmppEndpoint.java | 2 +- .../component/smpp/SmppConfigurationTest.java | 6 ++-- .../camel-snmp/src/main/docs/snmp-component.adoc | 2 +- .../apache/camel/component/snmp/SnmpEndpoint.java | 2 +- .../apache/camel/component/solr/SolrEndpoint.java | 10 +++++-- .../src/main/docs/splunk-component.adoc | 2 +- .../component/splunk/SplunkConfiguration.java | 4 +-- .../spring/batch/SpringBatchEndpoint.java | 2 +- .../camel/component/stomp/StompEndpoint.java | 12 +++++--- .../camel/component/thrift/ThriftEndpoint.java | 4 +++ .../camel-tika/src/main/docs/tika-component.adoc | 8 +++--- .../camel/component/tika/TikaConfiguration.java | 32 ++++++++-------------- .../twitter/timeline/TwitterTimelineEndpoint.java | 8 ++++++ .../endpoint/dsl/SplunkEndpointBuilderFactory.java | 7 ++--- .../endpoint/dsl/TikaEndpointBuilderFactory.java | 10 +++---- 17 files changed, 63 insertions(+), 54 deletions(-) diff --git a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java index 7758b9f..8c0015e 100644 --- a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java +++ b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java @@ -521,7 +521,7 @@ public class SmppConfiguration implements Cloneable { this.numberingPlanIndicator = numberingPlanIndicator; } - public boolean getUsingSSL() { + public boolean isUsingSSL() { return usingSSL; } diff --git a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConnectionFactory.java b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConnectionFactory.java index 8527cdd..ee9773c 100644 --- a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConnectionFactory.java +++ b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConnectionFactory.java @@ -85,7 +85,7 @@ public final class SmppConnectionFactory implements ConnectionFactory { try { Socket socket; SocketFactory socketFactory; - socketFactory = config.getUsingSSL() && config.getHttpProxyHost() == null ? SSLSocketFactory + socketFactory = config.isUsingSSL() && config.getHttpProxyHost() == null ? SSLSocketFactory .getDefault() : SocketFactory.getDefault(); if (config.getHttpProxyHost() != null) { // setup the proxy tunnel @@ -99,7 +99,7 @@ public final class SmppConnectionFactory implements ConnectionFactory { socket.connect(new InetSocketAddress(host, port), config.getEnquireLinkTimer()); } - if (config.getUsingSSL() && config.getHttpProxyHost() != null) { + if (config.isUsingSSL() && config.getHttpProxyHost() != null) { // Init the SSL socket which is based on the proxy socket SSLSocketFactory sslSocketFactory = (SSLSocketFactory)SSLSocketFactory.getDefault(); SSLSocket sslSocket = (SSLSocket)sslSocketFactory.createSocket(socket, host, port, true); diff --git a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppEndpoint.java b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppEndpoint.java index 47b0d0f..9345997 100644 --- a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppEndpoint.java +++ b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppEndpoint.java @@ -156,7 +156,7 @@ public class SmppEndpoint extends DefaultEndpoint { * @return the connection string */ public String getConnectionString() { - return (configuration.getUsingSSL() ? "smpps://" : "smpp://") + return (configuration.isUsingSSL() ? "smpps://" : "smpp://") + (getConfiguration().getSystemId() != null ? getConfiguration().getSystemId() + "@" : "") + getConfiguration().getHost() + ":" + getConfiguration().getPort(); diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java index ca03446..5ce9c90 100644 --- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java +++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java @@ -70,7 +70,7 @@ public class SmppConfigurationTest { assertEquals("ISO-8859-1", configuration.getEncoding()); assertEquals(0x00, configuration.getNumberingPlanIndicator()); assertEquals(0x00, configuration.getTypeOfNumber()); - assertEquals(false, configuration.getUsingSSL()); + assertEquals(false, configuration.isUsingSSL()); assertEquals(5000, configuration.getInitialReconnectDelay()); assertEquals(5000, configuration.getReconnectDelay()); assertEquals(null, configuration.getHttpProxyHost()); @@ -105,7 +105,7 @@ public class SmppConfigurationTest { assertEquals("UTF-8", configuration.getEncoding()); assertEquals(0x08, configuration.getNumberingPlanIndicator()); assertEquals(0x02, configuration.getTypeOfNumber()); - assertEquals(true, configuration.getUsingSSL()); + assertEquals(true, configuration.isUsingSSL()); assertEquals(5001, configuration.getInitialReconnectDelay()); assertEquals(5002, configuration.getReconnectDelay()); assertEquals("127.0.0.1", configuration.getHttpProxyHost()); @@ -164,7 +164,7 @@ public class SmppConfigurationTest { assertEquals(config.getEncoding(), configuration.getEncoding()); assertEquals(config.getNumberingPlanIndicator(), configuration.getNumberingPlanIndicator()); assertEquals(config.getTypeOfNumber(), configuration.getTypeOfNumber()); - assertEquals(config.getUsingSSL(), configuration.getUsingSSL()); + assertEquals(config.isUsingSSL(), configuration.isUsingSSL()); assertEquals(config.getInitialReconnectDelay(), configuration.getInitialReconnectDelay()); assertEquals(config.getReconnectDelay(), configuration.getReconnectDelay()); assertEquals(config.getHttpProxyHost(), configuration.getHttpProxyHost()); diff --git a/components/camel-snmp/src/main/docs/snmp-component.adoc b/components/camel-snmp/src/main/docs/snmp-component.adoc index 75b9106..ef63748 100644 --- a/components/camel-snmp/src/main/docs/snmp-component.adoc +++ b/components/camel-snmp/src/main/docs/snmp-component.adoc @@ -84,7 +84,7 @@ with the following path and query parameters: | Name | Description | Default | Type | *bridgeErrorHandler* (consumer) | Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions occurred while the consumer is trying to pickup incoming messages, or the likes, will now be processed as a message and handled by the routing Error Handler. By default the consumer will use the org.apache.camel.spi.ExceptionHandler to deal with exceptions, that will be logged at WARN or ERROR level and ignored. | false | boolean | *delay* (consumer) | Sets update rate in seconds | 60000 | long -| *oids* (consumer) | Defines which values you are interested in. Please have a look at the Wikipedia to get a better understanding. You may provide a single OID or a coma separated list of OIDs. Example: oids=1.3.6.1.2.1.1.3.0,1.3.6.1.2.1.25.3.2.1.5.1,1.3.6.1.2.1.25.3.5.1.1.1,1.3.6.1.2.1.43.5.1.1.11.1 | | String +| *oids* (consumer) | Defines which values you are interested in. Please have a look at the Wikipedia to get a better understanding. You may provide a single OID or a coma separated list of OIDs. Example: oids=1.3.6.1.2.1.1.3.0,1.3.6.1.2.1.25.3.2.1.5.1,1.3.6.1.2.1.25.3.5.1.1.1,1.3.6.1.2.1.43.5.1.1.11.1 | | OIDList | *protocol* (consumer) | Here you can select which protocol to use. You can use either udp or tcp. | udp | String | *retries* (consumer) | Defines how often a retry is made before canceling the request. | 2 | int | *sendEmptyMessageWhenIdle* (consumer) | If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead. | false | boolean diff --git a/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java b/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java index bf0b65e..7e86d721 100644 --- a/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java +++ b/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java @@ -79,7 +79,7 @@ public class SnmpEndpoint extends DefaultPollingEndpoint { private String snmpContextName; @UriParam private String snmpContextEngineId; - @UriParam(javaType = "java.lang.String") + @UriParam private OIDList oids = new OIDList(); @UriParam(label = "consumer", defaultValue = "false") private boolean treeList; diff --git a/components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrEndpoint.java b/components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrEndpoint.java index 26cd2a4..99e7d73 100644 --- a/components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrEndpoint.java +++ b/components/camel-solr/src/main/java/org/apache/camel/component/solr/SolrEndpoint.java @@ -84,9 +84,13 @@ public class SolrEndpoint extends DefaultEndpoint { /** * Set the ZooKeeper host information which the solrCloud could use, such as "zkhost=localhost:8123". */ - public void setZkHost(String zkHost) throws UnsupportedEncodingException { - String decoded = URLDecoder.decode(zkHost, "UTF-8"); - this.zkHost = decoded; + public void setZkHost(String zkHost) { + try { + String decoded = URLDecoder.decode(zkHost, "UTF-8"); + this.zkHost = decoded; + } catch (UnsupportedEncodingException e) { + throw new RuntimeException(e); + } } public String getZkHost() { diff --git a/components/camel-splunk/src/main/docs/splunk-component.adoc b/components/camel-splunk/src/main/docs/splunk-component.adoc index babcf10..c3a77d7 100644 --- a/components/camel-splunk/src/main/docs/splunk-component.adoc +++ b/components/camel-splunk/src/main/docs/splunk-component.adoc @@ -141,7 +141,7 @@ with the following path and query parameters: | *savedSearch* (consumer) | The name of the query saved in Splunk to run | | String | *search* (consumer) | The Splunk query to run | | String | *sendEmptyMessageWhenIdle* (consumer) | If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead. | false | boolean -| *streaming* (consumer) | Sets streaming mode. Streaming mode sends exchanges as they are received, rather than in a batch. | | Boolean +| *streaming* (consumer) | Sets streaming mode. Streaming mode sends exchanges as they are received, rather than in a batch. | false | boolean | *exceptionHandler* (consumer) | To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this option is not in use. By default the consumer will deal with exceptions, that will be logged at WARN or ERROR level and ignored. | | ExceptionHandler | *exchangePattern* (consumer) | Sets the exchange pattern when the consumer creates an exchange. | | ExchangePattern | *pollStrategy* (consumer) | A pluggable org.apache.camel.PollingConsumerPollingStrategy allowing you to provide your custom implementation to control error handling usually occurred during the poll operation before an Exchange have been created and being routed in Camel. | | PollingConsumerPoll Strategy diff --git a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/SplunkConfiguration.java b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/SplunkConfiguration.java index 9825805..564ef66 100644 --- a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/SplunkConfiguration.java +++ b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/SplunkConfiguration.java @@ -79,7 +79,7 @@ public class SplunkConfiguration { @UriParam(label = "consumer") private String initEarliestTime; @UriParam(label = "consumer") - private Boolean streaming; + private boolean streaming; public String getName() { return name; @@ -301,7 +301,7 @@ public class SplunkConfiguration { } public boolean isStreaming() { - return streaming != null ? streaming : false; + return streaming; } /** diff --git a/components/camel-spring-batch/src/main/java/org/apache/camel/component/spring/batch/SpringBatchEndpoint.java b/components/camel-spring-batch/src/main/java/org/apache/camel/component/spring/batch/SpringBatchEndpoint.java index bcb1e56..99ad97a 100644 --- a/components/camel-spring-batch/src/main/java/org/apache/camel/component/spring/batch/SpringBatchEndpoint.java +++ b/components/camel-spring-batch/src/main/java/org/apache/camel/component/spring/batch/SpringBatchEndpoint.java @@ -160,7 +160,7 @@ public class SpringBatchEndpoint extends DefaultEndpoint { this.jobFromHeader = jobFromHeader; } - public boolean getJobFromHeader() { + public boolean isJobFromHeader() { return jobFromHeader; } diff --git a/components/camel-stomp/src/main/java/org/apache/camel/component/stomp/StompEndpoint.java b/components/camel-stomp/src/main/java/org/apache/camel/component/stomp/StompEndpoint.java index edf8ef8..6d61c95 100644 --- a/components/camel-stomp/src/main/java/org/apache/camel/component/stomp/StompEndpoint.java +++ b/components/camel-stomp/src/main/java/org/apache/camel/component/stomp/StompEndpoint.java @@ -57,23 +57,27 @@ import static org.fusesource.stomp.client.Constants.UNSUBSCRIBE; @UriEndpoint(firstVersion = "2.12.0", scheme = "stomp", title = "Stomp", syntax = "stomp:destination", label = "messaging") public class StompEndpoint extends DefaultEndpoint implements AsyncEndpoint, HeaderFilterStrategyAware { + private CallbackConnection connection; + private Stomp stomp; + private final List<StompConsumer> consumers = new CopyOnWriteArrayList<>(); + @UriPath(description = "Name of the queue") @Metadata(required = true) private String destination; @UriParam private StompConfiguration configuration; - private CallbackConnection connection; - private Stomp stomp; @UriParam(label = "advanced", description = "To use a custom HeaderFilterStrategy to filter header to and from Camel message.") private HeaderFilterStrategy headerFilterStrategy; - private final List<StompConsumer> consumers = new CopyOnWriteArrayList<>(); - public StompEndpoint(String uri, StompComponent component, StompConfiguration configuration, String destination) { super(uri, component); this.configuration = configuration; this.destination = destination; } + public StompConfiguration getConfiguration() { + return configuration; + } + @Override public Producer createProducer() throws Exception { return new StompProducer(this); diff --git a/components/camel-thrift/src/main/java/org/apache/camel/component/thrift/ThriftEndpoint.java b/components/camel-thrift/src/main/java/org/apache/camel/component/thrift/ThriftEndpoint.java index ec8f69d..f3b5b24 100644 --- a/components/camel-thrift/src/main/java/org/apache/camel/component/thrift/ThriftEndpoint.java +++ b/components/camel-thrift/src/main/java/org/apache/camel/component/thrift/ThriftEndpoint.java @@ -45,6 +45,10 @@ public class ThriftEndpoint extends DefaultEndpoint { servicePackage = ThriftUtils.extractServicePackage(configuration.getService()); } + public ThriftConfiguration getConfiguration() { + return configuration; + } + @Override public Producer createProducer() throws Exception { ThriftProducer producer = new ThriftProducer(this, configuration); diff --git a/components/camel-tika/src/main/docs/tika-component.adoc b/components/camel-tika/src/main/docs/tika-component.adoc index 465f4b2..c5a99c4 100644 --- a/components/camel-tika/src/main/docs/tika-component.adoc +++ b/components/camel-tika/src/main/docs/tika-component.adoc @@ -57,7 +57,7 @@ with the following path and query parameters: [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type -| *operation* | *Required* Tika Operation. parse or detect | | TikaOperation +| *operation* | *Required* Tika Operation - parse or detect | | TikaOperation |=== @@ -68,9 +68,9 @@ with the following path and query parameters: |=== | Name | Description | Default | Type | *lazyStartProducer* (producer) | Whether the producer should be started lazy (on the first message). By starting lazy you can use this to allow CamelContext and routes to startup in situations where a producer may otherwise fail during starting and cause the route to fail being started. By deferring this startup to be lazy then the startup failure can be handled during routing messages via Camel's routing error handlers. Beware that when the first message is processed then creating and [...] -| *tikaConfig* (producer) | Tika Config | | TikaConfig -| *tikaConfigUri* (producer) | Tika Config Uri: The URI of tika-config.xml | | String -| *tikaParseOutputEncoding* (producer) | Tika Parse Output Encoding - Used to specify the character encoding of the parsed output. Defaults to Charset.defaultCharset() . | | String +| *tikaConfig* (producer) | To use a custom Tika config. | | TikaConfig +| *tikaConfigUri* (producer) | Tika Config Uri: The URI of tika-config.xml file to use. | | String +| *tikaParseOutputEncoding* (producer) | Tika Parse Output Encoding - Used to specify the character encoding of the parsed output. Defaults to Charset.defaultCharset(). | | String | *tikaParseOutputFormat* (producer) | Tika Output Format. Supported output formats. xml: Returns Parsed Content as XML. html: Returns Parsed Content as HTML. text: Returns Parsed Content as Text. textMain: Uses the boilerpipe library to automatically extract the main content from a web page. | xml | TikaParseOutputFormat | *basicPropertyBinding* (advanced) | Whether the endpoint should use basic property binding (Camel 2.x) or the newer property binding with additional capabilities | false | boolean | *synchronous* (advanced) | Sets whether synchronous processing should be strictly used, or Camel is allowed to use asynchronous processing (if supported). | false | boolean diff --git a/components/camel-tika/src/main/java/org/apache/camel/component/tika/TikaConfiguration.java b/components/camel-tika/src/main/java/org/apache/camel/component/tika/TikaConfiguration.java index 2919f40..2323784 100644 --- a/components/camel-tika/src/main/java/org/apache/camel/component/tika/TikaConfiguration.java +++ b/components/camel-tika/src/main/java/org/apache/camel/component/tika/TikaConfiguration.java @@ -16,18 +16,13 @@ */ package org.apache.camel.component.tika; -import java.io.IOException; import java.nio.charset.Charset; -import org.xml.sax.SAXException; - import org.apache.camel.spi.Metadata; import org.apache.camel.spi.UriParam; import org.apache.camel.spi.UriParams; import org.apache.camel.spi.UriPath; import org.apache.tika.config.TikaConfig; -import org.apache.tika.exception.TikaException; - @UriParams public class TikaConfiguration { @@ -49,9 +44,7 @@ public class TikaConfiguration { } /** - * - * Tika Operation. parse or detect - * + * Tika Operation - parse or detect */ public void setOperation(TikaOperation operation) { this.operation = operation; @@ -66,15 +59,13 @@ public class TikaConfiguration { } /** - * - * Tika Output Format. Supported output formats. + * Tika Output Format. Supported output formats. * <ul> * <li>xml: Returns Parsed Content as XML. </li> * <li>html: Returns Parsed Content as HTML. </li> * <li>text: Returns Parsed Content as Text. </li> * <li>textMain: Uses the <a href="http://code.google.com/p/boilerpipe/">boilerpipe</a> library to automatically extract the main content from a web page. </li> * </ul> - * */ public void setTikaParseOutputFormat(TikaParseOutputFormat tikaParseOutputFormat) { this.tikaParseOutputFormat = tikaParseOutputFormat; @@ -86,8 +77,7 @@ public class TikaConfiguration { /** * Tika Parse Output Encoding - Used to specify the character encoding of the parsed output. - * Defaults to Charset.defaultCharset() . - * + * Defaults to Charset.defaultCharset(). */ public void setTikaParseOutputEncoding(String tikaParseOutputEncoding) { this.tikaParseOutputEncoding = tikaParseOutputEncoding; @@ -98,9 +88,7 @@ public class TikaConfiguration { } /** - * - * Tika Config - * + * To use a custom Tika config. */ public void setTikaConfig(TikaConfig tikaConfig) { this.tikaConfig = tikaConfig; @@ -111,12 +99,14 @@ public class TikaConfiguration { } /** - * - * Tika Config Uri: The URI of tika-config.xml - * + * Tika Config Uri: The URI of tika-config.xml file to use. */ - public void setTikaConfigUri(String tikaConfigUri) throws TikaException, IOException, SAXException { + public void setTikaConfigUri(String tikaConfigUri) { this.tikaConfigUri = tikaConfigUri; - this.tikaConfig = new TikaConfig(tikaConfigUri); + try { + this.tikaConfig = new TikaConfig(tikaConfigUri); + } catch (Exception e) { + throw new RuntimeException(e); + } } } diff --git a/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/timeline/TwitterTimelineEndpoint.java b/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/timeline/TwitterTimelineEndpoint.java index 6edd3a6..5dd7dc7 100644 --- a/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/timeline/TwitterTimelineEndpoint.java +++ b/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/timeline/TwitterTimelineEndpoint.java @@ -51,6 +51,14 @@ public class TwitterTimelineEndpoint extends AbstractTwitterEndpoint { this.user = user; } + public String getUser() { + return user; + } + + public void setUser(String user) { + this.user = user; + } + @Override public Producer createProducer() throws Exception { switch (timelineType) { diff --git a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/SplunkEndpointBuilderFactory.java b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/SplunkEndpointBuilderFactory.java index 9da499a..374eb11 100644 --- a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/SplunkEndpointBuilderFactory.java +++ b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/SplunkEndpointBuilderFactory.java @@ -281,11 +281,11 @@ public interface SplunkEndpointBuilderFactory { * Sets streaming mode. Streaming mode sends exchanges as they are * received, rather than in a batch. * - * The option is a: <code>java.lang.Boolean</code> type. + * The option is a: <code>boolean</code> type. * * Group: consumer */ - default SplunkEndpointConsumerBuilder streaming(Boolean streaming) { + default SplunkEndpointConsumerBuilder streaming(boolean streaming) { setProperty("streaming", streaming); return this; } @@ -293,8 +293,7 @@ public interface SplunkEndpointBuilderFactory { * Sets streaming mode. Streaming mode sends exchanges as they are * received, rather than in a batch. * - * The option will be converted to a <code>java.lang.Boolean</code> - * type. + * The option will be converted to a <code>boolean</code> type. * * Group: consumer */ diff --git a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/TikaEndpointBuilderFactory.java b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/TikaEndpointBuilderFactory.java index dd1a395..aa507a3 100644 --- a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/TikaEndpointBuilderFactory.java +++ b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/TikaEndpointBuilderFactory.java @@ -39,7 +39,7 @@ public interface TikaEndpointBuilderFactory { return (AdvancedTikaEndpointBuilder) this; } /** - * Tika Config. + * To use a custom Tika config. * * The option is a: <code>org.apache.tika.config.TikaConfig</code> type. * @@ -50,7 +50,7 @@ public interface TikaEndpointBuilderFactory { return this; } /** - * Tika Config. + * To use a custom Tika config. * * The option will be converted to a * <code>org.apache.tika.config.TikaConfig</code> type. @@ -62,7 +62,7 @@ public interface TikaEndpointBuilderFactory { return this; } /** - * Tika Config Uri: The URI of tika-config.xml. + * Tika Config Uri: The URI of tika-config.xml file to use. * * The option is a: <code>java.lang.String</code> type. * @@ -74,7 +74,7 @@ public interface TikaEndpointBuilderFactory { } /** * Tika Parse Output Encoding - Used to specify the character encoding - * of the parsed output. Defaults to Charset.defaultCharset() . + * of the parsed output. Defaults to Charset.defaultCharset(). * * The option is a: <code>java.lang.String</code> type. * @@ -204,7 +204,7 @@ public interface TikaEndpointBuilderFactory { * Syntax: <code>tika:operation</code> * * Path parameter: operation (required) - * Tika Operation. parse or detect + * Tika Operation - parse or detect * The value can be one of: parse, detect */ default TikaEndpointBuilder tika(String path) {