This is an automated email from the ASF dual-hosted git repository.
coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new eda13e8 Remove the default password from the camel-smpp component
eda13e8 is described below
commit eda13e8506930360860ac6800cb606cea6606e07
Author: Colm O hEigeartaigh <cohei...@apache.org>
AuthorDate: Fri Jun 28 10:16:09 2019 +0100
Remove the default password from the camel-smpp component
---
.../camel/component/smpp/SmppConfiguration.java | 40 +++++++++++-----------
.../component/smpp/SmppConfigurationTest.java | 16 ++++-----
.../camel/component/smpp/SmppConsumerTest.java | 23 +++++++------
.../smpp/SmppProducerLazySessionCreationTest.java | 13 +++----
.../camel/component/smpp/SmppProducerTest.java | 21 ++++++------
5 files changed, 58 insertions(+), 55 deletions(-)
diff --git
a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java
b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java
index a613b6c..7758b9f 100644
---
a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java
+++
b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java
@@ -47,7 +47,7 @@ public class SmppConfiguration implements Cloneable {
@UriParam(label = "security", defaultValue = "smppclient", secret = true)
private String systemId = "smppclient";
@UriParam(label = "security", secret = true)
- private String password = "password";
+ private String password;
@UriParam(label = "common", defaultValue = "")
private String systemType = "";
@UriParam(label = "codec")
@@ -115,7 +115,7 @@ public class SmppConfiguration implements Cloneable {
/**
* A POJO which contains all necessary configuration parameters for the
SMPP connection
- *
+ *
* @param uri the full URI of the endpoint
*/
public void configureFromURI(URI uri) {
@@ -186,7 +186,7 @@ public class SmppConfiguration implements Cloneable {
public String getPassword() {
return password;
}
-
+
public byte getDataCoding() {
return dataCoding;
}
@@ -205,7 +205,7 @@ public class SmppConfiguration implements Cloneable {
public void setDataCoding(byte dataCoding) {
this.dataCoding = dataCoding;
}
-
+
public byte getAlphabet() {
return alphabet;
}
@@ -475,7 +475,7 @@ public class SmppConfiguration implements Cloneable {
public void setDestAddr(String destAddr) {
this.destAddr = destAddr;
}
-
+
public byte getTypeOfNumber() {
return typeOfNumber;
}
@@ -531,7 +531,7 @@ public class SmppConfiguration implements Cloneable {
public void setUsingSSL(boolean usingSSL) {
this.usingSSL = usingSSL;
}
-
+
public long getInitialReconnectDelay() {
return initialReconnectDelay;
}
@@ -675,30 +675,30 @@ public class SmppConfiguration implements Cloneable {
@Override
public String toString() {
- return "SmppConfiguration[usingSSL=" + usingSSL
+ return "SmppConfiguration[usingSSL=" + usingSSL
+ ", enquireLinkTimer=" + enquireLinkTimer
- + ", host=" + host
- + ", password=" + password
- + ", port=" + port
- + ", systemId=" + systemId
+ + ", host=" + host
+ + ", password=" + password
+ + ", port=" + port
+ + ", systemId=" + systemId
+ ", systemType=" + systemType
+ ", dataCoding=" + dataCoding
+ ", alphabet=" + alphabet
+ ", encoding=" + encoding
+ ", transactionTimer=" + transactionTimer
+ ", registeredDelivery=" + registeredDelivery
- + ", serviceType=" + serviceType
- + ", sourceAddrTon=" + sourceAddrTon
+ + ", serviceType=" + serviceType
+ + ", sourceAddrTon=" + sourceAddrTon
+ ", destAddrTon=" + destAddrTon
- + ", sourceAddrNpi=" + sourceAddrNpi
- + ", destAddrNpi=" + destAddrNpi
+ + ", sourceAddrNpi=" + sourceAddrNpi
+ + ", destAddrNpi=" + destAddrNpi
+ ", addressRange=" + addressRange
+ ", protocolId=" + protocolId
- + ", priorityFlag=" + priorityFlag
- + ", replaceIfPresentFlag=" + replaceIfPresentFlag
- + ", sourceAddr=" + sourceAddr
- + ", destAddr=" + destAddr
- + ", typeOfNumber=" + typeOfNumber
+ + ", priorityFlag=" + priorityFlag
+ + ", replaceIfPresentFlag=" + replaceIfPresentFlag
+ + ", sourceAddr=" + sourceAddr
+ + ", destAddr=" + destAddr
+ + ", typeOfNumber=" + typeOfNumber
+ ", numberingPlanIndicator=" + numberingPlanIndicator
+ ", initialReconnectDelay=" + initialReconnectDelay
+ ", reconnectDelay=" + reconnectDelay
diff --git
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java
index fe6e067..ca03446 100644
---
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java
+++
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConfigurationTest.java
@@ -37,7 +37,7 @@ import static org.junit.Assert.assertNotNull;
* JUnit test class for
<code>org.apache.camel.component.smpp.SmppConfiguration</code>
*/
public class SmppConfigurationTest {
-
+
private SmppConfiguration configuration;
@Before
@@ -54,7 +54,7 @@ public class SmppConfigurationTest {
assertEquals("", configuration.getAddressRange());
assertEquals(new Integer(5000), configuration.getEnquireLinkTimer());
assertEquals("localhost", configuration.getHost());
- assertEquals("password", configuration.getPassword());
+ assertEquals(null, configuration.getPassword());
assertEquals(new Integer(2775), configuration.getPort());
assertEquals(0x01, configuration.getPriorityFlag());
assertEquals(0x00, configuration.getProtocolId());
@@ -79,11 +79,11 @@ public class SmppConfigurationTest {
assertEquals(null, configuration.getHttpProxyPassword());
assertEquals(null, configuration.getSessionStateListener());
}
-
+
@Test
public void getterShouldReturnTheSetValues() {
setNoneDefaultValues(configuration);
-
+
assertEquals("1919", configuration.getDestAddr());
assertEquals(0x08, configuration.getDestAddrNpi());
assertEquals(0x02, configuration.getDestAddrTon());
@@ -119,7 +119,7 @@ public class SmppConfigurationTest {
@Test
public void getterShouldReturnTheConfigureValuesFromURI() throws
URISyntaxException {
configuration.configureFromURI(new
URI("smpp://client@127.0.0.1:2776"));
-
+
assertEquals("127.0.0.1", configuration.getHost());
assertEquals(new Integer(2776), configuration.getPort());
assertEquals("client", configuration.getSystemId());
@@ -142,7 +142,7 @@ public class SmppConfigurationTest {
public void cloneShouldReturnAnEqualInstance() {
setNoneDefaultValues(configuration);
SmppConfiguration config = configuration.copy();
-
+
assertEquals(config.getDestAddr(), configuration.getDestAddr());
assertEquals(config.getDestAddrNpi(), configuration.getDestAddrNpi());
assertEquals(config.getDestAddrTon(), configuration.getDestAddrTon());
@@ -174,14 +174,14 @@ public class SmppConfigurationTest {
assertEquals(config.getSessionStateListener(),
configuration.getSessionStateListener());
assertEquals(config.getProxyHeaders(),
configuration.getProxyHeaders());
}
-
+
@Test
public void toStringShouldListAllInstanceVariables() {
String expected = "SmppConfiguration["
+ "usingSSL=false, "
+ "enquireLinkTimer=5000, "
+ "host=localhost, "
- + "password=password, "
+ + "password=null, "
+ "port=2775, "
+ "systemId=smppclient, "
+ "systemType=, "
diff --git
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConsumerTest.java
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConsumerTest.java
index 1a1fd33..196fd13 100644
---
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConsumerTest.java
+++
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppConsumerTest.java
@@ -38,7 +38,7 @@ import static org.mockito.Mockito.when;
* JUnit test class for
<code>org.apache.camel.component.smpp.SmppConsumer</code>
*/
public class SmppConsumerTest {
-
+
private SmppConsumer consumer;
private SmppEndpoint endpoint;
private SmppConfiguration configuration;
@@ -50,16 +50,17 @@ public class SmppConsumerTest {
configuration = new SmppConfiguration();
configuration.setServiceType("CMT");
configuration.setSystemType("cp");
+ configuration.setPassword("password");
endpoint = mock(SmppEndpoint.class);
processor = mock(Processor.class);
session = mock(SMPPSession.class);
-
+
// the construction of SmppConsumer will trigger the getCamelContext
call
consumer = new SmppConsumer(
- endpoint,
+ endpoint,
configuration,
processor) {
-
+
SMPPSession createSMPPSession() {
return session;
}
@@ -79,9 +80,9 @@ public class SmppConsumerTest {
"");
when(session.connectAndBind("localhost", new Integer(2775),
expectedBindParameter))
.thenReturn("1");
-
+
consumer.doStart();
-
+
verify(session).setEnquireLinkTimer(5000);
verify(session).setTransactionTimer(10000);
verify(session).addSessionStateListener(isA(SessionStateListener.class));
@@ -93,20 +94,20 @@ public class SmppConsumerTest {
public void doStopShouldNotCloseTheSMPPSessionIfItIsNull() throws
Exception {
when(endpoint.getConnectionString())
.thenReturn("smpp://smppclient@localhost:2775");
-
+
consumer.doStop();
}
-
+
@Test
public void doStopShouldCloseTheSMPPSession() throws Exception {
doStartShouldStartANewSmppSession();
reset(endpoint, processor, session);
-
+
when(endpoint.getConnectionString())
.thenReturn("smpp://smppclient@localhost:2775");
-
+
consumer.doStop();
-
+
verify(session).removeSessionStateListener(isA(SessionStateListener.class));
verify(session).unbindAndClose();
}
diff --git
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerLazySessionCreationTest.java
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerLazySessionCreationTest.java
index ef45e87..d459a71 100644
---
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerLazySessionCreationTest.java
+++
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerLazySessionCreationTest.java
@@ -37,7 +37,7 @@ import static org.mockito.Mockito.when;
* JUnit test class for
<code>org.apache.camel.component.smpp.SmppProducer</code>
*/
public class SmppProducerLazySessionCreationTest {
-
+
private SmppProducer producer;
private SmppConfiguration configuration;
private SmppEndpoint endpoint;
@@ -49,9 +49,10 @@ public class SmppProducerLazySessionCreationTest {
configuration.setLazySessionCreation(true);
configuration.setServiceType("CMT");
configuration.setSystemType("cp");
+ configuration.setPassword("password");
endpoint = mock(SmppEndpoint.class);
session = mock(SMPPSession.class);
-
+
producer = new SmppProducer(endpoint, configuration) {
SMPPSession createSMPPSession() {
return session;
@@ -96,10 +97,10 @@ public class SmppProducerLazySessionCreationTest {
when(in.getHeader("CamelSmppSystemId", String.class)).thenReturn(null);
when(in.getHeader("CamelSmppPassword", String.class)).thenReturn(null);
command.execute(exchange);
-
+
producer.doStart();
producer.process(exchange);
-
+
verify(session).setEnquireLinkTimer(5000);
verify(session).setTransactionTimer(10000);
verify(session).addSessionStateListener(isA(SessionStateListener.class));
@@ -131,10 +132,10 @@ public class SmppProducerLazySessionCreationTest {
when(in.getHeader("CamelSmppSystemId",
String.class)).thenReturn("smppclient2");
when(in.getHeader("CamelSmppPassword",
String.class)).thenReturn("password2");
command.execute(exchange);
-
+
producer.doStart();
producer.process(exchange);
-
+
verify(session).connectAndBind("localhost", new Integer(2775),
expectedBindParameter);
}
}
diff --git
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerTest.java
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerTest.java
index 79b476c..b7c3e84 100644
---
a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerTest.java
+++
b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppProducerTest.java
@@ -36,7 +36,7 @@ import static org.mockito.Mockito.when;
* JUnit test class for
<code>org.apache.camel.component.smpp.SmppProducer</code>
*/
public class SmppProducerTest {
-
+
private SmppProducer producer;
private SmppConfiguration configuration;
private SmppEndpoint endpoint;
@@ -47,9 +47,10 @@ public class SmppProducerTest {
configuration = new SmppConfiguration();
configuration.setServiceType("CMT");
configuration.setSystemType("cp");
+ configuration.setPassword("password");
endpoint = mock(SmppEndpoint.class);
session = mock(SMPPSession.class);
-
+
producer = new SmppProducer(endpoint, configuration) {
SMPPSession createSMPPSession() {
return session;
@@ -72,9 +73,9 @@ public class SmppProducerTest {
when(session.connectAndBind("localhost", new Integer(2775),
expectedBindParameters))
.thenReturn("1");
when(endpoint.isSingleton()).thenReturn(true);
-
+
producer.doStart();
-
+
verify(session).setEnquireLinkTimer(5000);
verify(session).setTransactionTimer(10000);
verify(session).addSessionStateListener(isA(SessionStateListener.class));
@@ -89,7 +90,7 @@ public class SmppProducerTest {
producer.doStop();
}
-
+
@Test
public void doStopShouldCloseTheSMPPSession() throws Exception {
when(endpoint.getConnectionString())
@@ -98,11 +99,11 @@ public class SmppProducerTest {
producer.doStart();
producer.doStop();
-
+
verify(session).removeSessionStateListener(isA(SessionStateListener.class));
verify(session).unbindAndClose();
}
-
+
@Test
public void processInOnlyShouldExecuteTheCommand() throws Exception {
SmppBinding binding = mock(SmppBinding.class);
@@ -110,13 +111,13 @@ public class SmppProducerTest {
SmppCommand command = mock(SmppCommand.class);
when(endpoint.getBinding()).thenReturn(binding);
when(binding.createSmppCommand(session, exchange)).thenReturn(command);
-
+
producer.doStart();
producer.process(exchange);
-
+
verify(command).execute(exchange);
}
-
+
@Test
public void getterShouldReturnTheSetValues() {
assertSame(endpoint, producer.getEndpoint());
