This is an automated email from the ASF dual-hosted git repository.
nferraro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit c17f0be7281191b6ccd7cd5f93a6b2dcd00dcd66
Author: lburgazzoli <lburgazz...@gmail.com>
AuthorDate: Tue Jun 25 18:16:00 2019 +0200
Add timeout to maven operations #761 (add tests)
---
.../integrationplatform/initialize_test.go | 149 +++++++++++++++++++++
1 file changed, 149 insertions(+)
diff --git a/pkg/controller/integrationplatform/initialize_test.go
b/pkg/controller/integrationplatform/initialize_test.go
new file mode 100644
index 0000000..8260f3a
--- /dev/null
+++ b/pkg/controller/integrationplatform/initialize_test.go
@@ -0,0 +1,149 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integrationplatform
+
+import (
+ "context"
+ "testing"
+ "time"
+
+ "github.com/apache/camel-k/pkg/apis/camel/v1alpha1"
+ "github.com/apache/camel-k/pkg/util/log"
+ "github.com/apache/camel-k/pkg/util/test"
+ "github.com/stretchr/testify/assert"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+ k8sclient "sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+func TestTimeouts_Default(t *testing.T) {
+ ip := v1alpha1.IntegrationPlatform{}
+ ip.Namespace = "ns"
+ ip.Name = "camel-k"
+ ip.Spec.Cluster = v1alpha1.IntegrationPlatformClusterOpenShift
+
+ c, err := test.NewFakeClient(&ip)
+ assert.Nil(t, err)
+
+ h := NewInitializeAction()
+ h.InjectLogger(log.Log)
+ h.InjectClient(c)
+
+ err = h.Handle(context.TODO(), &ip)
+ assert.Nil(t, err)
+
+ key := k8sclient.ObjectKey{
+ Name: ip.Name,
+ Namespace: ip.Namespace,
+ }
+
+ answer := v1alpha1.NewIntegrationPlatform(ip.Name, ip.Namespace)
+
+ err = c.Get(context.TODO(), key, &answer)
+ assert.Nil(t, err)
+
+ n := answer.Spec.Build.Timeout.Duration.Seconds() * 0.75
+ d := (time.Duration(n) * time.Second).Truncate(time.Second)
+
+ assert.Equal(t, d, answer.Spec.Build.Maven.Timeout.Duration)
+ assert.Equal(t, 5*time.Minute, answer.Spec.Build.Timeout.Duration)
+}
+
+func TestTimeouts_MavenComputedFromBuild(t *testing.T) {
+ ip := v1alpha1.IntegrationPlatform{}
+ ip.Namespace = "ns"
+ ip.Name = "camel-k"
+ ip.Spec.Cluster = v1alpha1.IntegrationPlatformClusterOpenShift
+
+ timeout, err := time.ParseDuration("1m1ms")
+ assert.Nil(t, err)
+
+ ip.Spec.Build.Timeout = metav1.Duration{
+ Duration: timeout,
+ }
+
+ c, err := test.NewFakeClient(&ip)
+ assert.Nil(t, err)
+
+ h := NewInitializeAction()
+ h.InjectLogger(log.Log)
+ h.InjectClient(c)
+
+ err = h.Handle(context.TODO(), &ip)
+ assert.Nil(t, err)
+
+ key := k8sclient.ObjectKey{
+ Name: ip.Name,
+ Namespace: ip.Namespace,
+ }
+
+ answer := v1alpha1.NewIntegrationPlatform(ip.Name, ip.Namespace)
+
+ err = c.Get(context.TODO(), key, &answer)
+ assert.Nil(t, err)
+
+ n := answer.Spec.Build.Timeout.Duration.Seconds() * 0.75
+ d := (time.Duration(n) * time.Second).Truncate(time.Second)
+
+ assert.Equal(t, d, answer.Spec.Build.Maven.Timeout.Duration)
+ assert.Equal(t, 1*time.Minute, answer.Spec.Build.Timeout.Duration)
+}
+
+func TestTimeouts_Truncated(t *testing.T) {
+ ip := v1alpha1.IntegrationPlatform{}
+ ip.Namespace = "ns"
+ ip.Name = "camel-k"
+ ip.Spec.Cluster = v1alpha1.IntegrationPlatformClusterOpenShift
+
+ bt, err := time.ParseDuration("5m1ms")
+ assert.Nil(t, err)
+
+ ip.Spec.Build.Timeout = metav1.Duration{
+ Duration: bt,
+ }
+
+ mt, err := time.ParseDuration("2m1ms")
+ assert.Nil(t, err)
+
+ ip.Spec.Build.Maven.Timeout = metav1.Duration{
+ Duration: mt,
+ }
+
+ c, err := test.NewFakeClient(&ip)
+ assert.Nil(t, err)
+
+ h := NewInitializeAction()
+ h.InjectLogger(log.Log)
+ h.InjectClient(c)
+
+ err = h.Handle(context.TODO(), &ip)
+ assert.Nil(t, err)
+
+ key := k8sclient.ObjectKey{
+ Name: ip.Name,
+ Namespace: ip.Namespace,
+ }
+
+ answer := v1alpha1.NewIntegrationPlatform(ip.Name, ip.Namespace)
+
+ err = c.Get(context.TODO(), key, &answer)
+ assert.Nil(t, err)
+
+ assert.Equal(t, time.Duration(2*time.Minute),
answer.Spec.Build.Maven.Timeout.Duration)
+ assert.Equal(t, time.Duration(5*time.Minute),
answer.Spec.Build.Timeout.Duration)
+}
