This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push: new 8f9b477 Fixed CS 8f9b477 is described below commit 8f9b4776f62452fe4a287237b697c4dd62c21f56 Author: Claus Ibsen <claus.ib...@gmail.com> AuthorDate: Thu May 16 18:19:07 2019 +0200 Fixed CS --- .../main/java/org/apache/camel/FailedToStartRouteException.java | 7 +------ .../src/test/java/org/apache/camel/CamelExceptionsTest.java | 2 +- .../camel/component/bean/issues/BeanThisAdviceWithIssueTest.java | 8 ++++---- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/core/camel-api/src/main/java/org/apache/camel/FailedToStartRouteException.java b/core/camel-api/src/main/java/org/apache/camel/FailedToStartRouteException.java index 3399dbe..6ca5785 100644 --- a/core/camel-api/src/main/java/org/apache/camel/FailedToStartRouteException.java +++ b/core/camel-api/src/main/java/org/apache/camel/FailedToStartRouteException.java @@ -19,10 +19,9 @@ package org.apache.camel; /** * Exception when failing to start a {@link Route}. */ -// CHECKSTYLE:OFF public class FailedToStartRouteException extends RuntimeCamelException { - private String routeId; + private final String routeId; public FailedToStartRouteException(String routeId, String message) { super("Failed to start route " + routeId + " because of " + message); @@ -34,10 +33,6 @@ public class FailedToStartRouteException extends RuntimeCamelException { this.routeId = routeId; } - public FailedToStartRouteException(Throwable cause) { - super(cause); - } - public String getRouteId() { return routeId; } diff --git a/core/camel-core/src/test/java/org/apache/camel/CamelExceptionsTest.java b/core/camel-core/src/test/java/org/apache/camel/CamelExceptionsTest.java index f0f6374..be13610 100644 --- a/core/camel-core/src/test/java/org/apache/camel/CamelExceptionsTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/CamelExceptionsTest.java @@ -310,7 +310,7 @@ public class CamelExceptionsTest extends ContextTestSupport { @Test public void testFailedToStartRouteException() { - FailedToStartRouteException e = new FailedToStartRouteException(new IllegalArgumentException("Forced")); + FailedToStartRouteException e = new FailedToStartRouteException("myRoute", "Forced error", new IllegalArgumentException("Forced")); assertNotNull(e.getMessage()); assertIsInstanceOf(IllegalArgumentException.class, e.getCause()); } diff --git a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanThisAdviceWithIssueTest.java b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanThisAdviceWithIssueTest.java index a4a07a7..0ecd701 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanThisAdviceWithIssueTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanThisAdviceWithIssueTest.java @@ -1,13 +1,13 @@ -/** +/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at - * <p> - * http://www.apache.org/licenses/LICENSE-2.0 - * <p> + * + * http://www.apache.org/licenses/LICENSE-2.0 + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.