This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch sandbox/camel-3.x in repository https://gitbox.apache.org/repos/asf/camel.git
commit 2d04a01f38257cd824bd7af01b8bcca28f39e675 Author: Christoph Deppisch <[email protected]> AuthorDate: Thu Nov 22 09:11:45 2018 +0100 Avoid constants in interfaces --- .../google/bigquery/GoogleBigQueryConstants.java | 17 ++++++++++++----- .../calendar/internal/GoogleCalendarConstants.java | 13 ++++++++++--- .../stream/GoogleCalendarStreamConstants.java | 21 ++++++++++++++------- .../google/drive/internal/GoogleDriveConstants.java | 13 ++++++++++--- .../google/mail/internal/GoogleMailConstants.java | 13 ++++++++++--- .../mail/stream/GoogleMailStreamConstants.java | 21 ++++++++++++++------- 6 files changed, 70 insertions(+), 28 deletions(-) diff --git a/components/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConstants.java b/components/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConstants.java index 89d0eeb..cfd3c57 100644 --- a/components/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConstants.java +++ b/components/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConstants.java @@ -16,9 +16,16 @@ */ package org.apache.camel.component.google.bigquery; -public interface GoogleBigQueryConstants { - String TABLE_SUFFIX = "CamelGoogleBigQueryTableSuffix"; - String TABLE_ID = "CamelGoogleBigQueryTableId"; - String INSERT_ID = "CamelGoogleBigQueryInsertId"; - String PARTITION_DECORATOR = "CamelGoogleBigQueryPartitionDecorator"; +public final class GoogleBigQueryConstants { + public static final String TABLE_SUFFIX = "CamelGoogleBigQueryTableSuffix"; + public static final String TABLE_ID = "CamelGoogleBigQueryTableId"; + public static final String INSERT_ID = "CamelGoogleBigQueryInsertId"; + public static final String PARTITION_DECORATOR = "CamelGoogleBigQueryPartitionDecorator"; + + /** + * Prevent instantiation. + */ + private GoogleBigQueryConstants() { + super(); + } } diff --git a/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/internal/GoogleCalendarConstants.java b/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/internal/GoogleCalendarConstants.java index b604ad0..f25f84c 100644 --- a/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/internal/GoogleCalendarConstants.java +++ b/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/internal/GoogleCalendarConstants.java @@ -19,11 +19,18 @@ package org.apache.camel.component.google.calendar.internal; /** * Constants for GoogleCalendar component. */ -public interface GoogleCalendarConstants { +public final class GoogleCalendarConstants { // suffix for parameters when passed as exchange header properties - String PROPERTY_PREFIX = "CamelGoogleCalendar."; + public static final String PROPERTY_PREFIX = "CamelGoogleCalendar."; // thread profile name for this component - String THREAD_PROFILE_NAME = "CamelGoogleCalendar"; + public static final String THREAD_PROFILE_NAME = "CamelGoogleCalendar"; + + /** + * Prevent instantiation. + */ + private GoogleCalendarConstants() { + super(); + } } diff --git a/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConstants.java b/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConstants.java index c671c54..e590b74 100644 --- a/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConstants.java +++ b/components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConstants.java @@ -19,12 +19,19 @@ package org.apache.camel.component.google.calendar.stream; /** * Constants used in Camel Google Calendar Stream */ -public interface GoogleCalendarStreamConstants { +public final class GoogleCalendarStreamConstants { - String MAIL_TO = "CamelGoogleMailStreamTo"; - String MAIL_FROM = "CamelGoogleMailStreamFrom"; - String MAIL_CC = "CamelGoogleMailStreamCc"; - String MAIL_BCC = "CamelGoogleMailStreamBcc"; - String MAIL_SUBJECT = "CamelGoogleMailStreamSubject"; - String MAIL_ID = "CamelGoogleMailId"; + public static final String MAIL_TO = "CamelGoogleMailStreamTo"; + public static final String MAIL_FROM = "CamelGoogleMailStreamFrom"; + public static final String MAIL_CC = "CamelGoogleMailStreamCc"; + public static final String MAIL_BCC = "CamelGoogleMailStreamBcc"; + public static final String MAIL_SUBJECT = "CamelGoogleMailStreamSubject"; + public static final String MAIL_ID = "CamelGoogleMailId"; + + /** + * Prevent instantiation. + */ + private GoogleCalendarStreamConstants() { + super(); + } } diff --git a/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/internal/GoogleDriveConstants.java b/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/internal/GoogleDriveConstants.java index 9f824f5..d19ba20 100644 --- a/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/internal/GoogleDriveConstants.java +++ b/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/internal/GoogleDriveConstants.java @@ -19,11 +19,18 @@ package org.apache.camel.component.google.drive.internal; /** * Constants for GoogleDrive component. */ -public interface GoogleDriveConstants { +public final class GoogleDriveConstants { // suffix for parameters when passed as exchange header properties - String PROPERTY_PREFIX = "CamelGoogleDrive."; + public static final String PROPERTY_PREFIX = "CamelGoogleDrive."; // thread profile name for this component - String THREAD_PROFILE_NAME = "CamelGoogleDrive"; + public static final String THREAD_PROFILE_NAME = "CamelGoogleDrive"; + + /** + * Prevent instantiation. + */ + private GoogleDriveConstants() { + super(); + } } diff --git a/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/internal/GoogleMailConstants.java b/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/internal/GoogleMailConstants.java index f788ff3..a834549 100644 --- a/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/internal/GoogleMailConstants.java +++ b/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/internal/GoogleMailConstants.java @@ -19,11 +19,18 @@ package org.apache.camel.component.google.mail.internal; /** * Constants for GoogleMail component. */ -public interface GoogleMailConstants { +public final class GoogleMailConstants { // suffix for parameters when passed as exchange header properties - String PROPERTY_PREFIX = "CamelGoogleMail."; + public static final String PROPERTY_PREFIX = "CamelGoogleMail."; // thread profile name for this component - String THREAD_PROFILE_NAME = "CamelGoogleMail"; + public static final String THREAD_PROFILE_NAME = "CamelGoogleMail"; + + /** + * Prevent instantiation. + */ + private GoogleMailConstants() { + super(); + } } diff --git a/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/stream/GoogleMailStreamConstants.java b/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/stream/GoogleMailStreamConstants.java index ccd2c0f..e8ca7c2 100644 --- a/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/stream/GoogleMailStreamConstants.java +++ b/components/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/stream/GoogleMailStreamConstants.java @@ -19,12 +19,19 @@ package org.apache.camel.component.google.mail.stream; /** * Constants used in Camel Google Mail Stream */ -public interface GoogleMailStreamConstants { +public final class GoogleMailStreamConstants { - String MAIL_TO = "CamelGoogleMailStreamTo"; - String MAIL_FROM = "CamelGoogleMailStreamFrom"; - String MAIL_CC = "CamelGoogleMailStreamCc"; - String MAIL_BCC = "CamelGoogleMailStreamBcc"; - String MAIL_SUBJECT = "CamelGoogleMailStreamSubject"; - String MAIL_ID = "CamelGoogleMailId"; + public static final String MAIL_TO = "CamelGoogleMailStreamTo"; + public static final String MAIL_FROM = "CamelGoogleMailStreamFrom"; + public static final String MAIL_CC = "CamelGoogleMailStreamCc"; + public static final String MAIL_BCC = "CamelGoogleMailStreamBcc"; + public static final String MAIL_SUBJECT = "CamelGoogleMailStreamSubject"; + public static final String MAIL_ID = "CamelGoogleMailId"; + + /** + * Prevent instantiation. + */ + private GoogleMailStreamConstants() { + super(); + } }
