This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch camel-2.21.x in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/camel-2.21.x by this push: new f1cc54e CAMEL-12838 - Camel Twitter Send Direct Message Endpoint not working f1cc54e is described below commit f1cc54e98d327e0e1505c733457ff5c16433de09 Author: Andrea Cosentino <anco...@gmail.com> AuthorDate: Thu Sep 27 10:01:31 2018 +0200 CAMEL-12838 - Camel Twitter Send Direct Message Endpoint not working --- .../directmessage/DirectMessageProducer.java | 5 +- .../twitter/DirectMessageProducerTest.java | 76 ++++++++++++++++++++++ 2 files changed, 80 insertions(+), 1 deletion(-) diff --git a/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/directmessage/DirectMessageProducer.java b/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/directmessage/DirectMessageProducer.java index d8a7dc7..0c7c5fb 100644 --- a/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/directmessage/DirectMessageProducer.java +++ b/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/directmessage/DirectMessageProducer.java @@ -23,6 +23,8 @@ import org.apache.camel.component.twitter.TwitterEndpoint; import org.apache.camel.impl.DefaultProducer; import org.apache.camel.util.ObjectHelper; +import twitter4j.User; + /** * Produces text as a direct message. */ @@ -49,7 +51,8 @@ public class DirectMessageProducer extends DefaultProducer { throw new CamelExchangeException("Username not configured on TwitterEndpoint", exchange); } else { log.debug("Sending to: {} message: {}", toUsername, text); - endpoint.getProperties().getTwitter().sendDirectMessage(toUsername, text); + User userStatus = endpoint.getProperties().getTwitter().showUser(toUsername); + endpoint.getProperties().getTwitter().sendDirectMessage(userStatus.getId(), text); } } diff --git a/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/DirectMessageProducerTest.java b/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/DirectMessageProducerTest.java new file mode 100644 index 0000000..1a4db99 --- /dev/null +++ b/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/DirectMessageProducerTest.java @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.twitter; + +import java.util.Date; +import java.util.List; + +import org.apache.camel.EndpointInject; +import org.apache.camel.Exchange; +import org.apache.camel.ProducerTemplate; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.hamcrest.core.Is.is; + +/** + * Tests posting a twitter update with the default In Message Exchange Pattern + */ +public class DirectMessageProducerTest extends CamelTwitterTestSupport { + + private static final Logger LOG = LoggerFactory.getLogger(DirectMessageProducerTest.class); + + @EndpointInject(uri = "mock:result") + protected MockEndpoint resultEndpoint; + + @Test + public void testDirectMessage() throws Exception { + Date now = new Date(); + String tweet = "Test a tweet posted on " + now.toString(); + LOG.info("Tweet: " + tweet); + ProducerTemplate producerTemplate = context.createProducerTemplate(); + // send tweet to the twitter endpoint + producerTemplate.sendBody("direct:tweets", tweet); + + + resultEndpoint.expectedMessageCount(1); + resultEndpoint.expectedBodyReceived().body(String.class); + // Message headers should be preserved + resultEndpoint.assertIsSatisfied(); + + List<Exchange> tweets = resultEndpoint.getExchanges(); + assertNotNull(tweets); + assertThat(tweets.size(), is(1)); + String receivedTweet = tweets.get(0).getIn().getBody(String.class); + assertThat(receivedTweet, is(tweet)); + } + + protected RouteBuilder createRouteBuilder() { + return new RouteBuilder() { + public void configure() { + from("direct:tweets") + //.to("log:org.apache.camel.component.twitter?level=INFO&showAll=true&multiline=true") + .to("twitter-directmessage:user?" + getUriTokens()) + //.to("log:org.apache.camel.component.twitter?level=INFO&showAll=true&multiline=true") + .to("mock:result"); + } + }; + } +}