This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 5877786a5dc483e9340716abc6eeab0f0da69bf2
Author: Claus Ibsen <claus.ib...@gmail.com>
AuthorDate: Thu Mar 29 13:35:59 2018 +0200
CAMEL-10098: Added explanation to class javadoc about must use String
parameter type.
---
.../main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java | 5 +++++
.../src/main/java/org/apache/camel/spi/IdempotentRepository.java | 5 +++++
.../processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java | 5 +++++
3 files changed, 15 insertions(+)
diff --git
a/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
b/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
index f3e49d2..aff7304 100644
---
a/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
+++
b/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
@@ -33,6 +33,11 @@ import org.apache.camel.Exchange;
* <p/>
* This repository supports the operations to pass in the current exchange,
which can be needed by some implementations
* such as the JPA idempotent consumer.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the
generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the
Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link
IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*
* @version
*/
diff --git
a/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
b/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
index 6435c69..cc3724b 100644
--- a/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
+++ b/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
@@ -33,6 +33,11 @@ import org.apache.camel.Service;
* <p/>
* Implementations for the <a
href="http://camel.apache.org/idempotent-consumer.html";>idempotent consumer
EIP</a>
* should favor using {@link
org.apache.camel.spi.ExchangeIdempotentRepository} instead.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the
generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the
Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link
IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*
* @version
* @see org.apache.camel.spi.ExchangeIdempotentRepository
diff --git
a/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
b/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
index 3443ffb..d19e85e 100644
---
a/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
+++
b/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
@@ -42,6 +42,11 @@ import
org.springframework.transaction.support.TransactionTemplate;
* </ul>
* <p/>
* These methods should perform the named database operation.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the
generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the
Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link
IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*/
@ManagedResource(description = "JDBC IdempotentRepository")
public abstract class AbstractJdbcMessageIdRepository<T> extends
ServiceSupport implements IdempotentRepository<T> {
--
To stop receiving notification emails like this one, please contact
davscl...@apache.org.
